Refactor #22489: UINotifications::Base lives in wrong file - Foreman

Refactor #22489

UINotifications::Base lives in wrong file

Added by Marek Hulán almost 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Category:

Notifications

Target version:

1.17.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5271, https://github.com/theforeman/foreman/pull/5233

Fixed in Releases:

Found in Releases:

Description

app/services/ui_notifications.rb should only define the namespace module, base class should be defined under ui_notifications directory

Related issues

Associated revisions

Revision 0d332ecd (diff)
Added by Marek Hulán almost 3 years ago

Fixes #22489 - move the notification base class

History

#1 Updated by Marek Hulán almost 3 years ago

Tracker changed from Bug to Refactor

#2 Updated by Marek Hulán almost 3 years ago

This leads to a problem when plugin want to define its own notification builder like this

module UINotifications
  module RemoteExecutionJobs
    class BaseJobFinish < ::UINotifications::Base

That ends up with following error

/home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb:3:in `<module:RemoteExecutionJobs>': uninitialized constant UINotifications::Base (NameError)
        from /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb:2:in `<module:UINotifications>'
        from /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb:1:in `<top (required)>'
        from /home/ares/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies/interlock.rb:12:in `block in loading'
        from /home/ares/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/concurrency/share_lock.rb:149:in `exclusive'