Refactor #22489
closed
UINotifications::Base lives in wrong file
Added by Marek Hulán almost 7 years ago.
Updated over 6 years ago.
Description
app/services/ui_notifications.rb should only define the namespace module, base class should be defined under ui_notifications directory
- Tracker changed from Bug to Refactor
This leads to a problem when plugin want to define its own notification builder like this
module UINotifications
module RemoteExecutionJobs
class BaseJobFinish < ::UINotifications::Base
That ends up with following error
/home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb:3:in `<module:RemoteExecutionJobs>': uninitialized constant UINotifications::Base (NameError)
from /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb:2:in `<module:UINotifications>'
from /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb:1:in `<top (required)>'
from /home/ares/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies/interlock.rb:12:in `block in loading'
from /home/ares/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/concurrency/share_lock.rb:149:in `exclusive'
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/5233 added
- Translation missing: en.field_release set to 330
- Status changed from Ready For Testing to Closed
- Pull request https://github.com/theforeman/foreman/pull/5271 added
- Translation missing: en.field_release changed from 330 to 296
- Related to Bug #22649: foreman-remote-execution plugin breaks 1.17 install added
Setting to 1.17 since it is meant to fix the related issue.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by