Bug #22494: Rubocop can fail when there is ruby inside node_modules/ - Katello - Foreman

Actions

Copy link

Bug #22494

closed

Rubocop can fail when there is ruby inside node_modules/

Added by Eric Helms over 7 years ago. Updated almost 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Eric Helms

Category:

Tests

Target version:

Katello 3.6.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/7181

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description


/var/lib/workspace/workspace/katello-pr-test-test/node_modules/patternfly/node_modules/font-awesome-sass/lib/font_awesome/sass/rails/railtie.rb:9:9: W: Lint/BlockAlignment: end at 9, 8 is not aligned with initializer "font-awesome-sass.view_helpers" do at 7, 7.

        end

        ^^^

/var/lib/workspace/workspace/katello-pr-test-test/node_modules/patternfly/node_modules/font-awesome-sass/lib/font_awesome/sass/version.rb:3:15: C: Style/MutableConstant: Freeze mutable objects assigned to constants.

    VERSION = '4.7.0'

              ^^^^^^^

/var/lib/workspace/workspace/katello-pr-test-test/node_modules/patternfly/node_modules/font-awesome-sass/font-awesome-sass.gemspec:2:1: C: Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

lib = File.expand_path('../lib', __FILE__)

^

/var/lib/workspace/workspace/katello-pr-test-test/node_modules/patternfly/node_modules/font-awesome-sass/font-awesome-sass.gemspec:16:45: C: Style/SpecialGlobalVars: Prefer $INPUT_RECORD_SEPARATOR or $RS from the stdlib 'English' module (don't forget to require it) over $/.

  spec.files         = `git ls-files`.split($/)