Project

General

Profile

Actions

Refactor #22529

closed

Refactor Template rendering to use a proper rendering service

Added by Timo Goebel over 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

We should refactor template rendering to use a rendering service class and the template scope should also be a dedicated object and not some controller class.


Related issues 14 (1 open13 closed)

Related to Foreman Remote Execution - Refactor #24130: plugin should work with new template rendering engine from coreClosedTimo GoebelActions
Related to Boot disk - Refactor #24147: plugin should work with new template rendering engine from coreClosedTimo GoebelActions
Related to Discovery - Refactor #24148: plugin should work with new template rendering engine from coreClosedTimo GoebelActions
Related to Katello - Refactor #24149: Katello should use Foreman plugin API to register template macrosClosedTimo GoebelActions
Related to Foreman - Feature #24294: add snapshot tests for templatesClosedTimo GoebelActions
Related to Foreman - Feature #24359: Create localized copies of templates for version controlNewActions
Related to Foreman - Refactor #24484: snippet rendering should use source to find snippetClosedTimo GoebelActions
Related to Foreman - Refactor #24496: remove unattended helperClosedTimo GoebelActions
Related to Foreman - Bug #24503: snippets macro does not render a snippet partial from filesystemClosedTimo GoebelActions
Related to Katello - Bug #24513: React pages don't include Rails url_helpersClosedAndrew KofinkActions
Related to Foreman - Bug #25070: Macro snippet_if_exists no longer worksClosedMarek HulánActions
Related to Foreman - Bug #25128: Template Renderer: Variables loader registry is not kept when the class is inheritedClosedActions
Related to foreman_setup - Bug #25734: wrong number of arguments (given 1, expected 0)ClosedLukas ZapletalActions
Related to Foreman - Bug #25767: XenServer provisioning broken in 1.20ClosedShimon ShteinActions
Actions #1

Updated by google classroom over 6 years ago

removed spam bot comment

Actions #2

Updated by Timo Goebel over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Timo Goebel
Actions #3

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5683 added
Actions #4

Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
Actions #5

Updated by Timo Goebel about 6 years ago

  • Related to Refactor #24130: plugin should work with new template rendering engine from core added
Actions #6

Updated by Timo Goebel about 6 years ago

  • Related to Refactor #24147: plugin should work with new template rendering engine from core added
Actions #7

Updated by Timo Goebel about 6 years ago

  • Related to Refactor #24148: plugin should work with new template rendering engine from core added
Actions #8

Updated by Timo Goebel about 6 years ago

  • Related to Refactor #24149: Katello should use Foreman plugin API to register template macros added
Actions #9

Updated by Timo Goebel almost 6 years ago

Actions #10

Updated by Marek Hulán almost 6 years ago

  • Related to Feature #24359: Create localized copies of templates for version control added
Actions #11

Updated by Marek Hulán almost 6 years ago

  • Target version set to 1.20.0
  • Triaged set to No
  • Fixed in Releases 1.20.0 added
Actions #12

Updated by Anonymous almost 6 years ago

  • Status changed from Ready For Testing to Closed
Actions #13

Updated by Timo Goebel almost 6 years ago

  • Related to Refactor #24484: snippet rendering should use source to find snippet added
Actions #14

Updated by Timo Goebel almost 6 years ago

Actions #15

Updated by Timo Goebel almost 6 years ago

  • Related to Bug #24503: snippets macro does not render a snippet partial from filesystem added
Actions #16

Updated by Andrew Kofink almost 6 years ago

  • Related to Bug #24513: React pages don't include Rails url_helpers added
Actions #17

Updated by Marek Hulán almost 6 years ago

  • Related to Bug #25070: Macro snippet_if_exists no longer works added
Actions #18

Updated by Timo Goebel almost 6 years ago

  • Related to Bug #25128: Template Renderer: Variables loader registry is not kept when the class is inherited added
Actions #19

Updated by Shimon Shtein over 5 years ago

  • Related to Bug #25734: wrong number of arguments (given 1, expected 0) added
Actions #20

Updated by Shimon Shtein over 5 years ago

  • Related to Bug #25767: XenServer provisioning broken in 1.20 added
Actions

Also available in: Atom PDF