Bug #22698: clearing search filter does not clear search filter - Foreman

Bug #22698

clearing search filter does not clear search filter

Added by Ohad Levy over 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomer Brisker

Category:

Target version:

1.18.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5601, https://github.com/theforeman/foreman/pull/5434

Fixed in Releases:

Found in Releases:

Description

steps to reproduce

1. go to a page with search, set some filter condition and click search
2. click on the 'x' button to clear the search filter
3. click on search again, and note that the page retain its current search condition.

Associated revisions

Revision 2ce888d2 (diff)
Added by boaz shust about 4 years ago

Fixes #22698 - clear the search filter

clearing the search filter does not take place when submitting

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

History

#1 Updated by The Foreman Bot over 4 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/5434 added

#2 Updated by Ondřej Pražák over 4 years ago

Legacy Backlogs Release (now unused) set to 297

#3 Updated by Marek Hulán over 4 years ago

btw is this a 1.17 regression? could you add related issue if you have the introducing issue?

#4 Updated by Marek Hulán over 4 years ago

I think it has not been working long before 1.17, while it might be small enough fix for cherry-picking, I don't think we'd do 1.17.1 only because of this. The introducing issue was not provided. Of course leaving the decision on the owner of the release.