Bug #22711: Webpack uglifier errors out - Foreman

Bug #22711

Webpack uglifier errors out

Added by Anonymous over 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

High

Assignee:

Ohad Levy

Category:

JavaScript stack

Target version:

1.16.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5289, https://github.com/theforeman/foreman/pull/5288, https://github.com/theforeman/foreman/pull/5287, https://github.com/theforeman/foreman/pull/5283

Fixed in Releases:

Found in Releases:

Description

Currently webpack:compile fails with:

18:50:21 ERROR in vendor-4138154b37191d0e971d.js from UglifyJs
18:50:21 Unexpected token: name (format_format) [vendor-4138154b37191d0e971d.js:41555,4]

Associated revisions

Revision fdfc5429 (diff)
Added by Avi Sharvit over 4 years ago

Fixes #22711 - fix uglifyjs-webpack plugin

Revision eefb846c (diff)
Added by Michael Moll over 4 years ago

Refs #22711 - add uglifyjs-webpack-plugin to package.json

History

#1 Updated by Anonymous over 4 years ago

I think 1.16 and 1.17 need to get this, in order to have working builds.

#2 Updated by The Foreman Bot over 4 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/5277 added

#3 Updated by Anonymous over 4 years ago

Related to Bug #21857: uglifier 4.x fails to precompile assets added

#4 Updated by Anonymous over 4 years ago

Related to deleted (Bug #21857: uglifier 4.x fails to precompile assets)

#5 Updated by Anonymous over 4 years ago

Priority changed from Normal to High
Assignee deleted (~~Anonymous~~)
Status changed from Ready For Testing to New
Subject changed from Enable ES6 support for uglifier to Webpack uglifier errors out
Pull request deleted (~~https://github.com/theforeman/foreman/pull/5277~~)

Setting to high as this is currently blocking tests and package builds. AFAICT now, the root cause is not in the Rails asset pipeline but somewhere in the webpack chain.