Project

General

Profile

Bug #22751

Adding override values doesn't work with 1.17

Added by Tomáš Strachota over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Smart variables
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

The api docs for override values has changed in the foreman 1.17 and wrongly document expected types for 'value' and 'default_value' parameters. This results in hammer interpreting the type as a list and passing all the values in arrays.

Unfortunately this happens at multiple places in the api. Since the proper fix includes some tuning on hammer-cli side as well as adding a custom validator to the api and this issue blocks some other PRs that require 1.17 api exports, I propose to do a temporary fix on hammer side. The proper fix can be delivered later.


Related issues

Related to Foreman - Bug #22753: Some API parameters are wrongly documented as enum typesClosed2018-03-02

Associated revisions

Revision bfe13ff4 (diff)
Added by Tomas Strachota over 2 years ago

Fixes #22751 - temporary fix for override values

History

#1 Updated by The Foreman Bot over 2 years ago

  • Assignee set to Tomáš Strachota
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/357 added

#2 Updated by Tomáš Strachota over 2 years ago

  • Related to Bug #22753: Some API parameters are wrongly documented as enum types added

#3 Updated by Martin Bacovsky over 2 years ago

  • Legacy Backlogs Release (now unused) set to 342

#4 Updated by Anonymous over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF