Project

General

Profile

Bug #22758

Hammer product info does not parse the repositories info correctly

Added by roman plevka over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Hammer
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

[root@qe-nightly-rhel7 ~]# LANG=en_US.UTF-8 hammer -d -v -u admin -p changeme product info --name="foo" --organization-id="732"
...
[ INFO 2018-03-05T04:18:19 HammerCLI::MainCommand] Called with options: {"option_verbose"=>true, "option_debug"=>true, "option_username"=>"admin", "option_password"=>"***"}
[ INFO 2018-03-05T04:18:19 HammerCLIKatello::Product] Called with options: {}
[ INFO 2018-03-05T04:18:19 API] Server: https://qe-nightly-rhel7.foo.bar.com
[ INFO 2018-03-05T04:18:19 API] GET /katello/api/organizations/732/products
[DEBUG 2018-03-05T04:18:19 API] Params: {
"name" => "foo"
}
[DEBUG 2018-03-05T04:18:19 API] Headers: {
:params => {
"name" => "foo"
}
}
[DEBUG 2018-03-05T04:18:19 API] Using authenticator: HammerCLIForeman::Api::InteractiveBasicAuth
[DEBUG 2018-03-05T04:18:19 API] Response: {
"total" => 1,
"subtotal" => 1,
"page" => 1,
"per_page" => 100000,
"error" => nil,
"search" => nil,
"sort" => {
"by" => "name",
"order" => "asc"
},
"results" => [
[0] {
"id" => 4404,
"cp_id" => "122722695291",
"name" => "foo",
"label" => "foo",
"description" => nil,
"provider_id" => 1033,
"sync_plan_id" => nil,
"sync_summary" => {},
"gpg_key_id" => nil,
"sync_state" => nil,
"last_sync" => nil,
"last_sync_words" => nil,
"organization_id" => 732,
"organization" => {
"name" => "63icO2",
"label" => "63icO2",
"id" => 732
},
"sync_plan" => nil,
"repository_count" => 1
}
]
}
[DEBUG 2018-03-05T04:18:19 API] Response headers: {
:date => "Mon, 05 Mar 2018 09:18:19 GMT",
:server => "Apache/2.4.6 (Red Hat Enterprise Linux)",
:foreman_version => "1.18.0-develop",
:foreman_api_version => "2",
:apipie_checksum => "250aef2449d248af6eae5c857f8eb519",
:cache_control => "max-age=0, private, must-revalidate",
:x_request_id => "f39b3730-a7bd-460a-80fe-5e80ce5a46a9",
:x_runtime => "0.092007",
:content_security_policy => "default-src 'self'; child-src 'self'; connect-src 'self' ws: wss:; img-src 'self' data: *.gravatar.com; script-src 'unsafe-eval' 'unsafe-inline' 'self'; style-src 'unsafe-inline' 'self'",
:strict_transport_security => "max-age=631139040; includeSubdomains",
:x_content_type_options => "nosniff",
:x_download_options => "noopen",
:x_frame_options => "sameorigin",
:x_permitted_cross_domain_policies => "none",
:x_xss_protection => "1; mode=block",
:x_powered_by => "Phusion Passenger 4.0.53",
:set_cookie => [
[0] "_session_id=d3ad55b065653b2ba26ee9a377b600d2; path=/; secure; HttpOnly"
],
:etag => "W/\"7dfe955cac33dfa02105670282889bf9-gzip\"",
:status => "200 OK",
:vary => "Accept-Encoding",
:content_encoding => "gzip",
:content_length => "266",
:content_type => "application/json; charset=utf-8"
}
[ INFO 2018-03-05T04:18:19 HammerCLIKatello::Product::InfoCommand] Called with options: {"option_name"=>"foo", "option_organization_id"=>732, "option_id"=>4404}
[ INFO 2018-03-05T04:18:19 API] Server: https://qe-nightly-rhel7.foo.bar.com
[ INFO 2018-03-05T04:18:19 API] GET /katello/api/products/4404
[DEBUG 2018-03-05T04:18:19 API] Params: {}
[DEBUG 2018-03-05T04:18:19 API] Headers: {
:params => {}
}
[DEBUG 2018-03-05T04:18:19 API] Using authenticator: HammerCLIForeman::Api::InteractiveBasicAuth
[DEBUG 2018-03-05T04:18:19 API] Response: {
"redhat" => false,
"id" => 4404,
"cp_id" => "122722695291",
"name" => "foo",
"label" => "foo",
"description" => nil,
"provider_id" => 1033,
"sync_plan_id" => nil,
"sync_summary" => {},
"gpg_key_id" => nil,
"sync_state" => nil,
"last_sync" => nil,
"last_sync_words" => nil,
"organization_id" => 732,
"organization" => {
"name" => "63icO2",
"label" => "63icO2",
"id" => 732
},
"sync_plan" => nil,
"repository_count" => 1,
"created_at" => "2018-03-05 09:17:02 UTC",
"updated_at" => "2018-03-05 09:17:02 UTC",
"product_content" => [
[0] {
"enabled" => true,
"product_id" => 4404,
"name" => "bar",
"label" => "63icO2_foo_bar",
"vendor" => "Custom"
}
],
"available_content" => [
[0] {
"enabled" => true,
"product_id" => 4404,
"name" => "bar",
"label" => "63icO2_foo_bar",
"vendor" => "Custom"
}
],
"repositories" => [
[0] {
"name" => "bar",
"id" => 1061
}
],
"provider" => {
"name" => "Anonymous"
},
"sync_status" => {
"id" => nil,
"product_id" => nil,
"progress" => nil,
"sync_id" => nil,
"state" => nil,
"raw_state" => nil,
"start_time" => nil,
"finish_time" => nil,
"duration" => nil,
"display_size" => nil,
"size" => nil,
"is_running" => nil,
"error_details" => nil
},
"permissions" => {
"view_products" => true,
"edit_products" => true,
"destroy_products" => true,
"sync_products" => true
},
"published_content_view_ids" => [],
"active_task_count" => 0
}
[DEBUG 2018-03-05T04:18:19 API] Response headers: {
:date => "Mon, 05 Mar 2018 09:18:19 GMT",
:server => "Apache/2.4.6 (Red Hat Enterprise Linux)",
:foreman_version => "1.18.0-develop",
:foreman_api_version => "2",
:apipie_checksum => "250aef2449d248af6eae5c857f8eb519",
:cache_control => "max-age=0, private, must-revalidate",
:x_request_id => "a9375d60-531e-4c4d-b49c-895f6a8df785",
:x_runtime => "0.117248",
:content_security_policy => "default-src 'self'; child-src 'self'; connect-src 'self' ws: wss:; img-src 'self' data: *.gravatar.com; script-src 'unsafe-eval' 'unsafe-inline' 'self'; style-src 'unsafe-inline' 'self'",
:strict_transport_security => "max-age=631139040; includeSubdomains",
:x_content_type_options => "nosniff",
:x_download_options => "noopen",
:x_frame_options => "sameorigin",
:x_permitted_cross_domain_policies => "none",
:x_xss_protection => "1; mode=block",
:x_powered_by => "Phusion Passenger 4.0.53",
:set_cookie => [
[0] "_session_id=6f0386a9d1e3d906a1e4d82586cc91c9; path=/; secure; HttpOnly"
],
:etag => "W/\"64e212f504979fb6a74009e54535cc1c-gzip\"",
:status => "200 OK",
:vary => "Accept-Encoding",
:content_encoding => "gzip",
:content_length => "477",
:content_type => "application/json; charset=utf-8"
}
ID: 4404
Name: foo
Label: foo
Description:
Sync State:
Sync Plan ID:
GPG:
GPG Key ID:
GPG Key:
Organization: 63icO2
Readonly:
Deletable:
Content:
1) Repo Name:
URL:
Content Type:

Associated revisions

Revision d3cce829 (diff)
Added by Partha Aji about 3 years ago

Fixes #22758 - correct product content json

During a prior commit where the product content models and api got
refactored, some attributes of the content object were incorrectly
formatted. This caused the /GET /katello/api/products/<id> to ignore
contentUrl, type and name data for different product content. This
commit fixes the above issue

Expected:
"product_content" => [ {
"enabled" => true,
"product_id" => 634,
"content" => {
"id" => "1515479672098",
"type" => "yum",
"label" => "ACME_zoo_zoo",
"name" => "zoo",
"content_url" => "/custom/zoo/zoo",
"contentUrl" => "/custom/zoo/zoo",
},
}
.....
]

vs

Actual (output before this commit):
"product_content" => [ {
"enabled" => true,
"product_id" => 634,
"label" => "ACME_zoo_zoo",
"name" => "zoo",
"vendor" => "Red Hat"
}
.....
]

History

#1 Updated by roman plevka over 3 years ago

  • Subject changed from Katello - hammer product info does not parse the repositories info correctly to Hammer product info does not parse the repositories info correctly

#2 Updated by roman plevka over 3 years ago

  • Legacy Backlogs Release (now unused) set to 338

version: katello-nightly (provisioned on 2018-03-04)

#3 Updated by The Foreman Bot about 3 years ago

  • Assignee set to Partha Aji
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7366 added

#4 Updated by Partha Aji about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF