Project

General

Profile

Bug #22825

RepositoryTypeIcon tests failing after patternfly-react upgrade

Added by Walden Raines 7 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

> katello@1.0.0 test /Users/wraines/code/katello
> jest webpack

 FAIL  webpack/scenes/RedHatRepositories/components/__tests__/RepositoryTypeIcon.test.js
  ● RepositoryTypeIcon component › rendering › it should get rendered correctly

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot 1.

    - Snapshot
    + Received

    @@ -18,9 +18,7 @@
          ]
        }
      >
        <ListViewIcon
          name="fa-2x fa fa-question" 
    -     size="sm" 
    -     type="fa" 
        />
      </OverlayTrigger>

      at Object.<anonymous> (webpack/scenes/RedHatRepositories/components/__tests__/RepositoryTypeIcon.test.js:17:54)
          at new Promise (<anonymous>)
          at <anonymous>

  ● RepositoryTypeIcon component › rendering › it should get rendered correctly when type is provided

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot 1.

    - Snapshot
    + Received

    @@ -18,9 +18,7 @@
          ]
        }
      >
        <ListViewIcon
          name="fa-2x pficon-bundle" 
    -     size="sm" 
    -     type="fa" 
        />
      </OverlayTrigger>

      at Object.<anonymous> (webpack/scenes/RedHatRepositories/components/__tests__/RepositoryTypeIcon.test.js:25:54)
          at new Promise (<anonymous>)
          at <anonymous>

 › 2 snapshot tests failed.
 PASS  webpack/redux/reducers/RedHatRepositories/repositorySetRepositories.test.js
 PASS  webpack/redux/reducers/RedHatRepositories/sets.test.js
 PASS  webpack/redux/reducers/RedHatRepositories/enabled.test.js

Snapshot Summary
 › 2 snapshot tests failed in 1 test suite. Inspect your code changes or run with `npm test -- -u` to update them.

Test Suites: 1 failed, 3 passed, 4 total
Tests:       2 failed, 14 passed, 16 total
Snapshots:   2 failed, 2 total
Time:        2.757s


Related issues

Blocks Katello - Tracker #21151: Add react based Red Hat repositories page to katelloNew2017-09-28

Associated revisions

Revision 29d38292 (diff)
Added by Walden Raines 7 months ago

Fixes #22825: fix repository type icon tests after upgrade.

Fix RepositoryTypeIcon.test.js after patternfly-react upgrade.

http://projects.theforeman.org/issues/22825

History

#1 Updated by Walden Raines 7 months ago

  • Blocks Tracker #21151: Add react based Red Hat repositories page to katello added

#2 Updated by The Foreman Bot 7 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7228 added

#3 Updated by Walden Raines 6 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF