Project

General

Profile

Refactor #22880

Move to Minitest::Retry for integration tests

Added by Daniel Lobato Garcia about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Since our integration tests are quite flaky, at times because of DNS problems or similar, I suggest we move away from minitest-optional_retry (unmaintained) to minitest-retry which seems more maintained and provides more options. Moreover, we can just specify a limit of 3 retries, and print messages on consistent failures.

Associated revisions

Revision 4a2f1bc2 (diff)
Added by Daniel Lobato Garcia about 1 year ago

Fixes #22880 - Move to Minitest::Retry for integration tests

Since our integration tests are quite flaky, at times because of DNS
problems or similar, I suggest we move away from minitest-optional_retry
(unmaintained) to minitest-retry which seems more maintained and
provides more options. Moreover, we can just specify a limit of 3
retries, and print messages on consistent failures.

History

#1 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Daniel Lobato Garcia
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5318 added

#2 Updated by Tomer Brisker about 1 year ago

  • Legacy Backlogs Release (now unused) set to 330

#3 Updated by Anonymous about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF