Project

General

Profile

Refactor #22938

test 'should remove the key pair on compute resource deletion' fails with Rails 5.2

Added by Michael Moll 9 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Michael Moll
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5912
Team Backlog:
Fixed in Releases:
1.20.0
Found in Releases:

Description

Reverting https://github.com/rails/rails/commit/a286c32cc0ccf253b495abe983ffffd5146153d3 makes the test green again

Related issues

Related to Foreman - Bug #19631: ActiveRecord::RecordNotSaved when deleting compute resources with key pairsClosed2017-05-23
Blocks Foreman - Tracker #21834: Rails 5.2 upgrade tasksClosed

Associated revisions

Revision ccdbc5bf (diff)
Added by Michael Moll 4 months ago

Fixes #22938 - refactor key pair removal on CR deletion test (#5912)

It fails on Rails 5.2 otherwise

History

#1 Updated by Michael Moll 9 months ago

  • Related to Bug #19631: ActiveRecord::RecordNotSaved when deleting compute resources with key pairs added

#2 Updated by Michael Moll 9 months ago

#3 Updated by The Foreman Bot 5 months ago

  • Assignee set to Michael Moll
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5912 added

#4 Updated by Michael Moll 4 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Tomer Brisker 2 months ago

  • Fixed in Releases 1.20.0 added

Also available in: Atom PDF