Bug #23031: ISC DHCP new parser is still unable to parse DUID - Smart Proxy - Foreman

Actions

Copy link

Bug #23031

closed

ISC DHCP new parser is still unable to parse DUID

Added by Lukas Pramuk over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

Foreman - 1.18.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/571, https://github.com/theforeman/smart-proxy/pull/604

Fixed in Releases:

Foreman - 1.18.0

Found in Releases:

Red Hat JIRA:

Description

The new parser fails to parse the line in /var/lib/dhcpd/dhcpd.leases:

E, [2018-03-27T00:06:23.726811 ] ERROR -- : Couldn't enable 'dhcp_isc': 
in /var/lib/dhcpd/dhcpd.leases:6 at 1, expect token [ keyword_server_duid ]

 ^
E, [2018-03-27T00:06:23.727078 ] ERROR -- : Disabling all modules in the group ['dhcp_isc', 'dhcp'] due to a failure in one of them: 
in /var/lib/dhcpd/dhcpd.leases:6 at 1, expect token [ keyword_server_duid ]

The "winning" server duid is:

# The format of this file is documented in the dhcpd.leases(5) manual page.
# This lease file was written by isc-dhcp-4.2.5

server-duid "\000\001\000\001\"L{\010RT\000A\377\305";

(standard unmodified ISC DHCP from RHEL7.4)

foreman-proxy-1.18.0-0.develop.201802282028gitaf41016.el7.noarch
dhcp-4.2.5-58.el7_4.3.x86_64

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Lukas Pramuk over 6 years ago

deleted line, restarted dhcpd, got new duid, new and failing:

server-duid "\000\001\000\001\"M\033\317RT\000A\377\305";

Actions

Copy link

Updated by The Foreman Bot over 6 years ago

Status changed from New to Ready For Testing
Assignee set to Anonymous
Pull request https://github.com/theforeman/smart-proxy/pull/571 added

Actions

Copy link

Updated by Anonymous over 6 years ago

Status changed from Ready For Testing to Closed
% Done changed from 0 to 100

Applied in changeset aaaa77371dbe8467d3815685d8c4f3c330c952ce.

Actions

Copy link

Updated by Lukas Zapletal over 6 years ago

Translation missing: en.field_release set to 330

Actions

Copy link

Updated by Anonymous over 6 years ago

Related to Bug #23433: ISC DHCP new parser my break when parsing lease uids added

Actions

Copy link

Updated by Jorick Astrego over 6 years ago

I've tried the patch in this issue after trying the patch in https://projects.theforeman.org/issues/20826

But I still get the following error on Katello 3.5/foreman 1.16:

E, [2018-05-01T13:50:43.338532 ] ERROR -- : Couldn't enable 'dhcp_isc': 
in /var/lib/dhcpd/dhcpd.leases:6 at 1, expect token [ include_keyword ]

 ^
E, [2018-05-01T13:50:43.338747 ] ERROR -- : Disabling all modules in the group ['dhcp_isc', 'dhcp'] due to a failure in one of them: 
in /var/lib/dhcpd/dhcpd.leases:6 at 1, expect token [ include_keyword ]

But not the keyword_server_duid error I expected:

in /var/lib/dhcpd/dhcpd.leases:6 at 1, expect token [ keyword_server_duid ]

My DUID is:

cat /var/lib/dhcpd/dhcpd.leases# The format of this file is documented in the dhcpd.leases(5) manual page.
# This lease file was written by isc-dhcp-4.2.5

server-duid "\000\001\000\001\"{\032\342\000\032J\026\001w";

To be sure I also replaced the file with https://github.com/theforeman/smart-proxy/blob/develop/modules/dhcp_common/isc/configuration_parser.rb to no avail. And I'm not able to update foreman as it's tied to Katello.

Actions

Copy link