Refactor #23200: Change asset to use webpack, scss and babel - Discovery - Foreman

Actions

Copy link

Refactor #23200

open

Change asset to use webpack, scss and babel

Added by Ido Kanner about 7 years ago. Updated about 7 years ago.

Status:

Ready For Testing

Priority:

Low

Assignee:

Ido Kanner

Category:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_discovery/pull/421

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Current version of discovery was not converted to the way foreman is regarding assets -> webpack as builder, scss for styling and babel for javascript.
Further more, there are many inline styling at the current codebase that needs to be extracted to external styesheet resource.

Actions

Copy link

Updated by Daniel Lobato Garcia about 7 years ago

I understand it must be changed to the new stack at some point, but just doing it for the sake of it isn't worth it IMO.
I recently had to migrate the stack from Remote Execution to do what you mention here, in #13333 (https://github.com/theforeman/foreman_remote_execution/commit/899f01e06c5682f1cc9b0ab858e1c57ff672268d) in case you want to add something new.

Actions

Copy link