Project

General

Profile

Bug #23204

inconsitent puppet environment naming in hammer

Added by Ales Dujicek over 1 year ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Hosts
Target version:
-

Description

host create/update commands use environment

# hammer host create --help | grep environment
 --environment ENVIRONMENT_NAME                      Environment name
 --environment-id ENVIRONMENT_ID

but host info reports puppet environment

# hammer host info --id 1 | head -n 5
Id:                       1
Name:                     hostname..
Puppet Environment:       production
Puppet CA Proxy:          hostname..
Puppet Master Proxy:      hostname..

environment was changed to puppet environment in 6e83c9d82183f39dd4fd611698c0437409e1ee7a
http://projects.theforeman.org/issues/18750

tfm-rubygem-hammer_cli_katello-0.11.0-1.201804051800git94089a6.el7.noarch
tfm-rubygem-hammer_cli-0.13.pre.develop-1.201803232224gite493035.el7.noarch
tfm-rubygem-hammer_cli_foreman-0.13.pre.develop-1.201804041834git768148d.el7.noarch


Related issues

Related to Hammer CLI - Bug #26057: Cannot create hostgroup with --environmentClosed

Associated revisions

Revision 1862075e (diff)
Added by Oleh Fedorenko 4 months ago

Fixes #23204 - Consistent puppet environment naming in hammer

Revision bf31bbee
Added by Shira Maximov 4 months ago

Merge pull request #401 from ofedoren/bug-23204-puppet-environment

Fixes #23204 - Consistent puppet environment naming in hammer

History

#1 Updated by Tomáš Strachota over 1 year ago

  • Category set to Hosts

I agree that it would be better to name the parameters --puppet-environment instead of --environment. We should also consistently change the hostgroup command and possibly others that use --environment.

One implementation note:
When --puppet-environment is introduced, --environment should be hidden with a deprecation warning to keep backward compatibility. We can then remove it in the next version.

#2 Updated by Oleh Fedorenko 10 months ago

  • Assignee set to Oleh Fedorenko
  • Status changed from New to Assigned

#3 Updated by The Foreman Bot 10 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/401 added

#4 Updated by Oleh Fedorenko 7 months ago

  • Related to Bug #26057: Cannot create hostgroup with --environment added

#5 Updated by John Mitsch 4 months ago

  • Pull request https://github.com/Katello/hammer-cli-katello/pull/629 added

#6 Updated by John Mitsch 4 months ago

  • Bugzilla link set to 1713222

#7 Updated by Oleh Fedorenko 4 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by The Foreman Bot 2 months ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/437 added

Also available in: Atom PDF