Project

General

Profile

Actions

Bug #23204

closed

inconsitent puppet environment naming in hammer

Added by Ales Dujicek about 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Hosts
Target version:
-
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

host create/update commands use environment

# hammer host create --help | grep environment
 --environment ENVIRONMENT_NAME                      Environment name
 --environment-id ENVIRONMENT_ID

but host info reports puppet environment

# hammer host info --id 1 | head -n 5
Id:                       1
Name:                     hostname..
Puppet Environment:       production
Puppet CA Proxy:          hostname..
Puppet Master Proxy:      hostname..

environment was changed to puppet environment in 6e83c9d82183f39dd4fd611698c0437409e1ee7a
http://projects.theforeman.org/issues/18750

tfm-rubygem-hammer_cli_katello-0.11.0-1.201804051800git94089a6.el7.noarch
tfm-rubygem-hammer_cli-0.13.pre.develop-1.201803232224gite493035.el7.noarch
tfm-rubygem-hammer_cli_foreman-0.13.pre.develop-1.201804041834git768148d.el7.noarch


Related issues 1 (0 open1 closed)

Related to Hammer CLI - Bug #26057: Cannot create hostgroup with --environmentClosedOleh FedorenkoActions
Actions #1

Updated by Tomáš Strachota about 6 years ago

  • Category set to Hosts

I agree that it would be better to name the parameters --puppet-environment instead of --environment. We should also consistently change the hostgroup command and possibly others that use --environment.

One implementation note:
When --puppet-environment is introduced, --environment should be hidden with a deprecation warning to keep backward compatibility. We can then remove it in the next version.

Actions #2

Updated by Oleh Fedorenko over 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Oleh Fedorenko
Actions #3

Updated by The Foreman Bot over 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/401 added
Actions #4

Updated by Oleh Fedorenko about 5 years ago

  • Related to Bug #26057: Cannot create hostgroup with --environment added
Actions #5

Updated by John Mitsch almost 5 years ago

  • Pull request https://github.com/Katello/hammer-cli-katello/pull/629 added
Actions #6

Updated by John Mitsch almost 5 years ago

  • Bugzilla link set to 1713222
Actions #7

Updated by Oleh Fedorenko almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #8

Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/437 added
Actions

Also available in: Atom PDF