Project

General

Profile

Bug #23225

breadcrumb switcher on host show page breaks if vm tab fails to load

Added by Tomer Brisker 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

the host vm tab only catches `ActionView::Template::Error`, which works if the error is in the template rendering, but if `find_vm_by_uuid` fails it throws a `ActiveRecord::RecordNotFound` exception which isn't caught by the controller, leading to the generic controller reply which includes the entire layout - including JS which is executed and breaks all the JS on the page.


Related issues

Related to Foreman - Feature #22855: Add redux container for breadcrumb switcherClosed2018-03-12

Associated revisions

Revision f694d292 (diff)
Added by Amir Fefer 8 months ago

Fixes #23225 - fix vm tab js error in host page

History

#1 Updated by Tomer Brisker 8 months ago

  • Related to Feature #22855: Add redux container for breadcrumb switcher added

#2 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5437 added

#3 Updated by Tomer Brisker 8 months ago

  • Legacy Backlogs Release (now unused) set to 330

#4 Updated by Amir Fefer 8 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF