Actions
Refactor #23234
closedremove friendly_id <5.0 workarounds
Difficulty:
Triaged:
No
Description
With Rails 5.2:
- message: 'Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "CASE WHEN \"hostgroups\".\"title\" = ''928644347'' THEN 1 ELSE 0 END". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql().' callstack: app/controllers/api/base_controller.rb:407:in `prioritize_friendly_name_records'
app/controllers/api/base_controller.rb:378 says: "#Should be replaced after moving to friendly_id version >= 5.0"
This should be re-done now in a Rails 5.2 friendlier way.
Updated by Anonymous over 6 years ago
- Related to Bug #8343: API resource_scope ignores options added
Updated by Anonymous over 6 years ago
- Blocks Tracker #21834: Rails 5.2 upgrade tasks added
Updated by Anonymous over 6 years ago
- Blocks deleted (Tracker #21834: Rails 5.2 upgrade tasks)
Updated by Anonymous over 6 years ago
- Related to Tracker #21834: Rails 5.2 upgrade tasks added
Updated by Anonymous over 6 years ago
- Related to Refactor #23300: Do not use string interpolation when composing SQL queries. added
Updated by Anonymous over 5 years ago
- Blocks Tracker #24837: Rails 6.0 Tracker added
Updated by Tomer Brisker over 4 years ago
- Related to Refactor #23806: raise gem dependencies to Rails 5.2 compatible versions added
Updated by Tomer Brisker over 4 years ago
- Status changed from New to Assigned
- Assignee set to Tomer Brisker
Updated by The Foreman Bot over 4 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7289 added
Updated by Tomer Brisker over 4 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 5fb56030950982f424caeb38c69af27731d9581b.
Updated by The Foreman Bot over 4 years ago
- Pull request https://github.com/theforeman/foreman/pull/7328 added
Updated by Tomer Brisker about 3 years ago
- Related to Bug #32704: The /api/usergroups/:usergroup_id/external_usergroups API is not accepting 1-group as the name of usergroup added
Actions