Bug #23242: foreman-installer does not install hammer openscap plugin - Katello - Foreman

Actions

Copy link

Bug #23242

closed

foreman-installer does not install hammer openscap plugin

Added by Ales Dujicek over 6 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Chris Roberts

Category:

Installer

Target version:

Katello 3.8.0

Difficulty:

easy

Triaged:

Bugzilla link:

Pull request:

https://github.com/Katello/katello-installer/pull/612

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

foreman-installer should install hammer cli openscap plugin if you enable opencap

# foreman-installer --scenario katello --enable-foreman-plugin-openscap --enable-foreman-proxy-plugin-openscap --foreman-admin-password changeme  -s
Installing             Done                                               [100%]
  Success!
  * Katello is running at https://localhost.localdomain
      Initial credentials are admin / changeme
  * To install an additional Foreman proxy on separate machine continue by running:

      foreman-proxy-certs-generate --foreman-proxy-fqdn "$FOREMAN_PROXY" --certs-tar "/root/$FOREMAN_PROXY-certs.tar" 
  The full log is at /var/log/foreman-installer/katello.log

# hammer scap-content
Error: No such sub-command 'scap-content'.

See: 'hammer --help'.

# rpm -q tfm-rubygem-hammer_cli_foreman_openscap
package tfm-rubygem-hammer_cli_foreman_openscap is not installed

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Ales Dujicek over 6 years ago

Related to Feature #16802: Hammer CLI scap plugin install support via foreman-installer added

Actions

Copy link

Updated by Marek Hulán over 6 years ago

I think that should only happen if you also install hammer which is not always the case. CC Ewoud, I think you had some PoC for the $subject, is this a duplicate?

Actions

Copy link

Updated by Ales Dujicek over 6 years ago

tfm-rubygem-hammer_cli is installed as a dependency of katello-common, so it is always installed, isn't it?

Actions

Copy link

Updated by Ewoud Kohl van Wijngaarden over 6 years ago

It's not: https://github.com/theforeman/foreman-packaging/blob/93a35b8a0c68f4bb27fc6540940410ee44447f0d/packages/katello/katello/katello.spec#L137-L139

There is a --enable-foreman-cli-openscap parameter to the installer which should do what you want.

We currently do not automatically detect which plugins are needed (nor are there other hammer plugins in the installer). I am working on this (https://github.com/theforeman/puppet-foreman/pull/636 adds more classes) but my experiment on using datacat to automatically include the correct plugin classes doesn't appear to work (this code is only local). Not sure if that's ever going to work.

Actions

Copy link

Updated by Ales Dujicek over 6 years ago

Aha! katello scenario doesn't know it:

# foreman-installer --scenario katello   --enable-foreman-cli-openscap 
ERROR: Unrecognised option '--enable-foreman-cli-openscap'

See: 'foreman-installer --help'

Thank you

Actions

Copy link

Updated by Ewoud Kohl van Wijngaarden over 6 years ago

Ah right, the katello scenario. There we miss the option. You can try to add foreman::cli::openscap: true to your answers file /etc/foreman-installer/katello-answers.yaml (similar to https://github.com/theforeman/foreman-installer/blob/c9bede90d1ee0a2392fa829b09e60ff697b3bbf3/config/foreman-answers.yaml#L22) but it may cause issues with missing caches.

Actions

Copy link