Bug #23290
closed
React + Turbolinks integration break when submitting forms
Description
In the react-engine, we listen to turbolinks to clean all the react components when moving between pages:
https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/common/MountingService.js#L15
When performing form-submit (edit host, save), the event isn't triggering and we got the same components mounted twice into the dom.
For example:
go to hosts > click edit > click submit > click the breadcrumb sibling selector and pick another host.
its lands in another_host/edit because it uses the breadcrumb-bar from the previews mounting.
Updated by The Foreman Bot over 6 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/5462 added
Updated by Avi Sharvit over 6 years ago
- Translation missing: en.field_release set to 330
- Triaged set to No
Updated by Avi Sharvit over 6 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset b976723b58ad34ef9af77816541b42efc76c1b2a.
Updated by The Foreman Bot over 6 years ago
- Pull request https://github.com/theforeman/foreman/pull/5791 added
Updated by
Updated by Marek Hulán over 6 years ago
- Related to Bug #24320: Unable to provision on Vmware, no storage data submitted added
Updated by Marek Hulán over 6 years ago
- Status changed from Closed to New
- Target version deleted (
1.18.0) - Fixed in Releases deleted (
1.18.0)
Reopening, this does not seem to be fixed. #24320 in fact plans to revert the fix as it didn't seem to help, see https://github.com/theforeman/foreman/pull/5864#issuecomment-406555558 for more info
Updated by Tomer Brisker over 6 years ago
- Status changed from New to Closed
- Target version set to 1.18.0
- Fixed in Releases 1.18.0 added
Closing again. This has been shipped already in 1.18.0. Please open a new issue if needed for tracking regression caused by reverting this change.
Updated by Marek Hulán over 6 years ago
- Status changed from Closed to New
- Target version deleted (
1.18.0) - Fixed in Releases deleted (
1.18.0)
Tomer, this is not fixed. The linked PR didn't solve the issue and it can still be reproduced on 1.18.
Updated by Marek Hulán over 6 years ago
- Status changed from New to Closed
- Fixed in Releases 1.18.0 added
After a discussion on IRC, turns out it fixed one instance of the problem, so keeping at 1.18 as closed. Revert is already in develop and another fix should be applies, so cloning the issue for tracking.
Updated by Marek Hulán over 6 years ago
- Copied to Bug #24345: Breadcrumbs isn't refreshed properly after visiting host edit form added