React + Turbolinks integration break when submitting forms
In the react-engine, we listen to turbolinks to clean all the react components when moving between pages:
When performing form-submit (edit host, save), the event isn't triggering and we got the same components mounted twice into the dom.
go to hosts > click edit > click submit > click the breadcrumb sibling selector and pick another host.
its lands in another_host/edit because it uses the breadcrumb-bar from the previews mounting.
#7 Updated by Marek Hulán almost 2 years ago
- Target version deleted (
- Status changed from Closed to New
- Fixed in Releases deleted (
Reopening, this does not seem to be fixed. #24320 in fact plans to revert the fix as it didn't seem to help, see https://github.com/theforeman/foreman/pull/5864#issuecomment-406555558 for more info
#10 Updated by Marek Hulán almost 2 years ago
- Status changed from New to Closed
- Fixed in Releases 1.18.0 added
After a discussion on IRC, turns out it fixed one instance of the problem, so keeping at 1.18 as closed. Revert is already in develop and another fix should be applies, so cloning the issue for tracking.