Refactor #23344: Don't use expects in setup blocks - Foreman

Actions

Refactor #23344

closed

Don't use expects in setup blocks

Added by Lukas Zapletal almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Tests

Target version:

-

Difficulty:

Triaged:

No

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5471

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

It makes no sense, expectations should be part of (particular) tests, stubs should be used in setup blocks.

Actions

#1

Updated by The Foreman Bot almost 6 years ago

Status changed from New to Ready For Testing
Assignee set to Lukas Zapletal
Pull request https://github.com/theforeman/foreman/pull/5471 added

Actions

#2

Updated by Tomer Brisker over 5 years ago

Fixed in Releases 1.20.0 added

Actions

#3

Updated by Lukas Zapletal over 5 years ago

Status changed from Ready For Testing to Closed

Applied in changeset fab566de67bc664d17928cb713a4b207e256bdab.

Actions

Also available in: Atom PDF