Project

General

Profile

Bug #23386

Can't exit fullscreen mode in the editor using the escape key

Added by boaz shust 6 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
-
Target version:
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Pressing the escape key is supposed to exit from the fullscreen mode in the editor (in the partition templates, for instance). However, it doesn't work in the current version.

How to produce:
1) Login to Foreman
2) On the left (vertical) menu choose "Hosts" > "Partition Tables"
3) Click on one of the items in the table, for example "FreeBSD"
4) Scroll down and click on the "Fullscreen" button below the "Template" section
5) Press the escape key on the keyboard

Expected: exiting the fullscreen mode (like as you will when clicking on "Exit Fullscreen").
Received: nothing.

Associated revisions

Revision de7ea0a8 (diff)
Added by boaz shust 6 months ago

Fixes #23386 - Exit fullscreen when pressing ESC

Pressing the escape key should make the editor exit
the fullscreen mode. Nonetheless, when this key is pressed
the "exit_fullscreen_editor" function is called but
it was renamed to "exitFullscreen" which ends up with an error
message in the console.

In this patch, I updated the called function to be "exitFullscreen"
so it will be possible to exit fullscreen when escape key is pressed.

Signed-off-by: Boaz Shuster <>

History

#1 Updated by Tomer Brisker 6 months ago

  • Project changed from Foreman Maintain to Foreman

#2 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5490 added

#3 Updated by boaz shust 6 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker 6 months ago

  • Legacy Backlogs Release (now unused) set to 330

#5 Updated by Tomer Brisker about 2 months ago

  • Triaged set to No
  • Fixed in Releases 1.19.0 added

Also available in: Atom PDF