Bug #23433
ISC DHCP new parser my break when parsing lease uids
Difficulty:
Triaged:
Related issues
Associated revisions
History
#1
Updated by Dmitri Dolguikh 9 months ago
Updated by - Related to Bug #23031: ISC DHCP new parser is still unable to parse DUID added
#2
Updated by Huaqing Z 9 months ago
Updated by The literal regex is still broken.
def server_duid
Rsec::Fail.reset
keyword = word('server-duid').fail 'keyword_server_duid'
anything = /[^;,{}\s]+/.r
literal = /"([^"]|\")*"/.r
fails on
server-duid "\000\001\000\001\"vt\346\000PV\225S\347";
Changing the regex to
literal = /"([^"]|\\\")*"/.r
Though you could just literally do /".*"/ and rely on greedy regex match to fix the issue and simplify the code.
#3
Updated by The Foreman Bot 9 months ago
Updated by - Assignee set to Dmitri Dolguikh
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/583 added
#4
Updated by Anonymous 8 months ago
- % Done changed from 0 to 100
- Status changed from Ready For Testing to Closed
Applied in changeset 14a7505ffb8a57fd787edfc47b9fbd379399029c.
#5
Updated by Ivan Necas 8 months ago
Updated by - Legacy Backlogs Release (now unused) set to 330
I guess this should be pulled into 1.18 release
#6
Updated by Timo Goebel 8 months ago
Updated by 1.17 branch would be even better. Unfortunately, I can't update the release field.
#7
Updated by The Foreman Bot 7 months ago
- Pull request https://github.com/theforeman/smart-proxy/pull/588 added
#8
Updated by Lukas Zapletal 7 months ago
Updated by - Legacy Backlogs Release (now unused) changed from 330 to 360
- Category set to DHCP
Requesting backport into 1.17, this is an important one: #23784
#9
Updated by Han Boetes 7 months ago
Updated by I concur, this is an important patch. For anyone wanting to try the patch on 1.17:
- wget https://github.com/theforeman/smart-proxy/pull/588.diff
- edit the file and remove the "test" chunk below.
- cd /usr/share/foreman-proxy/
- patch -p1 -i ~/588.diff
- service foreman-proxy restart
#10
Updated by Ian Freislich 4 months ago
Updated by - Related to Bug #24978: ISC DHCP parser does not support DDNS entries added
Fixes #23433 - lease uids are now parsed correctly