Project

General

Profile

Bug #23433

ISC DHCP new parser my break when parsing lease uids

Added by Dmitri Dolguikh over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dmitri Dolguikh
Category:
DHCP
Target version:
1.17.2
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/588, https://github.com/theforeman/smart-proxy/pull/583
Fixed in Releases:
Found in Releases:
Foreman - 1.17.1

Related issues

Related to Smart Proxy - Bug #23031: ISC DHCP new parser is still unable to parse DUIDClosed
Related to Smart Proxy - Bug #24978: ISC DHCP parser does not support DDNS entriesClosed

Associated revisions

Revision 14a7505f (diff)
Added by Dmitri Dolguikh about 4 years ago

Fixes #23433 - lease uids are now parsed correctly

History

#1 Updated by Dmitri Dolguikh over 4 years ago

  • Related to Bug #23031: ISC DHCP new parser is still unable to parse DUID added

#2 Updated by Huaqing Z over 4 years ago

The literal regex is still broken.

        def server_duid
          Rsec::Fail.reset
          keyword = word('server-duid').fail 'keyword_server_duid'
          anything = /[^;,{}\s]+/.r
          literal = /"([^"]|\")*"/.r

fails on

server-duid "\000\001\000\001\"vt\346\000PV\225S\347";

Changing the regex to

          literal = /"([^"]|\\\")*"/.r

Though you could just literally do /".*"/ and rely on greedy regex match to fix the issue and simplify the code.

#3 Updated by The Foreman Bot over 4 years ago

  • Assignee set to Dmitri Dolguikh
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/583 added

#4 Updated by Anonymous about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#5 Updated by Ivan Necas about 4 years ago

  • Legacy Backlogs Release (now unused) set to 330

I guess this should be pulled into 1.18 release

#6 Updated by Timo Goebel about 4 years ago

1.17 branch would be even better. Unfortunately, I can't update the release field.

#7 Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/588 added

#8 Updated by Lukas Zapletal about 4 years ago

  • Legacy Backlogs Release (now unused) changed from 330 to 360
  • Category set to DHCP

Requesting backport into 1.17, this is an important one: #23784

#9 Updated by Han Boetes about 4 years ago

I concur, this is an important patch. For anyone wanting to try the patch on 1.17:

#10 Updated by Ian Freislich almost 4 years ago

  • Related to Bug #24978: ISC DHCP parser does not support DDNS entries added

Also available in: Atom PDF