Actions
Bug #23433
closed
ISC DHCP new parser my break when parsing lease uids
Difficulty:
Triaged:
Updated by Anonymous over 5 years ago
- Related to Bug #23031: ISC DHCP new parser is still unable to parse DUID added
Updated by Huaqing Z over 5 years ago
The literal regex is still broken.
def server_duid
Rsec::Fail.reset
keyword = word('server-duid').fail 'keyword_server_duid'
anything = /[^;,{}\s]+/.r
literal = /"([^"]|\")*"/.r
fails on
server-duid "\000\001\000\001\"vt\346\000PV\225S\347";
Changing the regex to
literal = /"([^"]|\\\")*"/.r
Though you could just literally do /".*"/ and rely on greedy regex match to fix the issue and simplify the code.
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Assignee set to Anonymous
- Pull request https://github.com/theforeman/smart-proxy/pull/583 added
Updated by Anonymous over 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 14a7505ffb8a57fd787edfc47b9fbd379399029c.
Updated by Ivan Necas over 5 years ago
- translation missing: en.field_release set to 330
I guess this should be pulled into 1.18 release
Updated by Timo Goebel over 5 years ago
1.17 branch would be even better. Unfortunately, I can't update the release field.
Updated by The Foreman Bot over 5 years ago
- Pull request https://github.com/theforeman/smart-proxy/pull/588 added
Updated by Lukas Zapletal over 5 years ago
- Category set to DHCP
- translation missing: en.field_release changed from 330 to 360
Requesting backport into 1.17, this is an important one: #23784
Updated by Han Boetes over 5 years ago
I concur, this is an important patch. For anyone wanting to try the patch on 1.17:
- wget https://github.com/theforeman/smart-proxy/pull/588.diff
- edit the file and remove the "test" chunk below.
- cd /usr/share/foreman-proxy/
- patch -p1 -i ~/588.diff
- service foreman-proxy restart
Updated by Ian Freislich about 5 years ago
- Related to Bug #24978: ISC DHCP parser does not support DDNS entries added
Actions