Project

General

Profile

Bug #23483

edit Foreman license info so that GitHub recognizes it

Added by Andrea Kao 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Development tools
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

GitHub uses a library called Licensee to identify a project's license type. It shows this information in the status bar and via the API if it can unambiguously identify the license.

Currently, Licensee does not properly detect Foreman's license as GPL 3.0. When I run Licensee locally on the remote Foreman repo, here is the output I get:

$ licensee detect https://github.com/theforeman/foreman
License:        Other
Matched files:  LICENSE, README.md, package.json
LICENSE:
  Content hash:  a17b7fcbdc64255d04d0b05e6642373a8ccdf97f
  License:       Other
  Closest licenses:
    GPL-3.0 similarity:   77.68%
    AGPL-3.0 similarity:  74.68%
    LGPL-2.1 similarity:  53.60%
README.md:
  Content hash:  18f341307338ee217d08193931fa550b30ed563b
  License:       Other
  Closest licenses:
    WTFPL similarity:    5.00%
    MS-RL similarity:    2.34%
    BSL-1.0 similarity:  1.75%
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     GNU General Public License v3.0

Associated revisions

Revision 08bc2344 (diff)
Added by Andrea Kao 4 months ago

Fixes #23483: edit Foreman license info for GitHub UI

GitHub uses a library called Licensee to identify a project's license
type. It shows this information in the status bar and via the API if it
can unambiguously identify the license.

This commit modifies LICENSE so that it begins with the full text of
the GPL 3.0 license. The text that was previously at the beginning of
LICENSE has been moved to the relevant section of the README, which has
been renamed to "Licensing". At the bottom of the "Licensing" section,
there is a note that mentions to the reader that they can reference
LICENSE to see the full text of not only the GPL 3.0 license, but also
all licenses related to Foreman's dependencies.

Collectively, these changes allow Licensee to successfully identify the
license type of Foreman as GPL 3.0.

Signed-off-by: Andrea Kao <>

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5521 added

#2 Updated by Ohad Levy 4 months ago

  • Legacy Backlogs Release (now unused) set to 353

#3 Updated by Andrea Kao 4 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#4 Updated by Ewoud Kohl van Wijngaarden 2 months ago

  • Triaged set to No
  • Category set to Development tools

Also available in: Atom PDF