Project

General

Profile

Refactor #23492

SettingTest#test_first_or_create_works fails with Rails 5.2

Added by Michael Moll 12 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Low
Assignee:
Michael Moll
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5847
Team Backlog:
Fixed in Releases:
1.20.0
Found in Releases:

Description

SettingTest#test_first_or_create_works:
NoMethodError: undefined method `to_sym' for nil:NilClass
Did you mean?  to_m
    app/models/setting.rb:207:in `create'
    test/models/setting_test.rb:218:in `block in test_first_or_create_works'
    test/models/setting_test.rb:216:in `test_first_or_create_works'

Related issues

Blocks Foreman - Tracker #21834: Rails 5.2 upgrade tasksClosed

History

#1 Updated by The Foreman Bot 12 months ago

  • Pull request https://github.com/theforeman/foreman/pull/5527 added

#2 Updated by Michael Moll 12 months ago

#3 Updated by Michael Moll 9 months ago

  • Status changed from Ready For Testing to Closed
  • Fixed in Releases 1.20.0 added
  • Pull request https://github.com/theforeman/foreman/pull/5847 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/5527)

9c853eeccc879756a2eea03c667762702e83cbc8 did include this

Also available in: Atom PDF