Bug #23559: Breadcrumbs switcher on trends page doesn't work for predefined trend types - Foreman

Actions

Copy link

Bug #23559

closed

Breadcrumbs switcher on trends page doesn't work for predefined trend types

Added by Tomáš Strachota over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Amir Fefer

Category:

Web Interface

Target version:

1.19.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5551

Fixed in Releases:

1.19.0

Found in Releases:

Red Hat JIRA:

Description

Predefined trends ( = other than fact trends) have hardcoded names and API returns name = null. That results in empty lines in the breadcrumb switcher and several js warnings when the switcher is opened:

warning.js:33 Warning: Failed prop type: The prop `resourceSwitcherItems[0].name` is marked as required in `BreadcrumbBar`, but its value is `null`.
    in BreadcrumbBar (created by Connect(BreadcrumbBar))
    in Connect(BreadcrumbBar)
    in Provider
warning.js:33 Warning: Failed prop type: The prop `resources[0].name` is marked as required in `BreadcrumbSwitcher`, but its value is `null`.
    in BreadcrumbSwitcher (created by BreadcrumbBar)
    in BreadcrumbBar (created by Connect(BreadcrumbBar))
    in Connect(BreadcrumbBar)
    in Provider
warning.js:33 Warning: Failed prop type: The prop `resources[0].name` is marked as required in `BreadcrumbSwitcherPopover`, but its value is `null`.
    in BreadcrumbSwitcherPopover (created by BreadcrumbSwitcher)
    in BreadcrumbSwitcher (created by BreadcrumbBar)
    in ol (created by Breadcrumb)
    in Breadcrumb (created by Breadcrumb)
    in Breadcrumb (created by Breadcrumb)
    in Breadcrumb (created by BreadcrumbBar)
    in div (created by BreadcrumbBar)
    in BreadcrumbBar (created by Connect(BreadcrumbBar))
    in Connect(BreadcrumbBar)
    in Provider
warning.js:33 Warning: Failed prop type: The prop `children` is marked as required in `EllipisWithTooltip`, but its value is `null`.
    in EllipisWithTooltip (created by BreadcrumbSwitcherPopover)
    in BreadcrumbSwitcherPopover (created by BreadcrumbSwitcher)
    in Position (created by Overlay)
    in Transition (created by Fade)
    in Fade (created by Overlay)
    in RootCloseWrapper (created by Overlay)
    in Portal (created by Overlay)
    in Overlay (created by Overlay)
    in Overlay (created by BreadcrumbSwitcher)
    in div (created by BreadcrumbSwitcher)
    in BreadcrumbSwitcher (created by BreadcrumbBar)
    in ol (created by Breadcrumb)
    in Breadcrumb (created by Breadcrumb)
    in Breadcrumb (created by Breadcrumb)
    in Breadcrumb (created by BreadcrumbBar)
    in div (created by BreadcrumbBar)
    in BreadcrumbBar (created by Connect(BreadcrumbBar))
    in Connect(BreadcrumbBar)
    in Provider

Expected results:
The switcher should display the same names as the index table.

Related issues 1 (0 open — 1 closed)