Bug #23559
Breadcrumbs switcher on trends page doesn't work for predefined trend types
Pull request:
Fixed in Releases:
Found in Releases:
Description
Predefined trends ( = other than fact trends) have hardcoded names and API returns name = null. That results in empty lines in the breadcrumb switcher and several js warnings when the switcher is opened:
warning.js:33 Warning: Failed prop type: The prop `resourceSwitcherItems[0].name` is marked as required in `BreadcrumbBar`, but its value is `null`. in BreadcrumbBar (created by Connect(BreadcrumbBar)) in Connect(BreadcrumbBar) in Provider warning.js:33 Warning: Failed prop type: The prop `resources[0].name` is marked as required in `BreadcrumbSwitcher`, but its value is `null`. in BreadcrumbSwitcher (created by BreadcrumbBar) in BreadcrumbBar (created by Connect(BreadcrumbBar)) in Connect(BreadcrumbBar) in Provider warning.js:33 Warning: Failed prop type: The prop `resources[0].name` is marked as required in `BreadcrumbSwitcherPopover`, but its value is `null`. in BreadcrumbSwitcherPopover (created by BreadcrumbSwitcher) in BreadcrumbSwitcher (created by BreadcrumbBar) in ol (created by Breadcrumb) in Breadcrumb (created by Breadcrumb) in Breadcrumb (created by Breadcrumb) in Breadcrumb (created by BreadcrumbBar) in div (created by BreadcrumbBar) in BreadcrumbBar (created by Connect(BreadcrumbBar)) in Connect(BreadcrumbBar) in Provider warning.js:33 Warning: Failed prop type: The prop `children` is marked as required in `EllipisWithTooltip`, but its value is `null`. in EllipisWithTooltip (created by BreadcrumbSwitcherPopover) in BreadcrumbSwitcherPopover (created by BreadcrumbSwitcher) in Position (created by Overlay) in Transition (created by Fade) in Fade (created by Overlay) in RootCloseWrapper (created by Overlay) in Portal (created by Overlay) in Overlay (created by Overlay) in Overlay (created by BreadcrumbSwitcher) in div (created by BreadcrumbSwitcher) in BreadcrumbSwitcher (created by BreadcrumbBar) in ol (created by Breadcrumb) in Breadcrumb (created by Breadcrumb) in Breadcrumb (created by Breadcrumb) in Breadcrumb (created by BreadcrumbBar) in div (created by BreadcrumbBar) in BreadcrumbBar (created by Connect(BreadcrumbBar)) in Connect(BreadcrumbBar) in Provider
Expected results:
The switcher should display the same names as the index table.
Related issues
Associated revisions
History
#1
Updated by Tomáš Strachota over 2 years ago
- Related to Bug #23527: enable breadcrumbs switcher in trends pages added
#2
Updated by The Foreman Bot over 2 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/5551 added
#3
Updated by Tomáš Strachota over 2 years ago
- Legacy Backlogs Release (now unused) set to 353
#4
Updated by Amir Fefer over 2 years ago
- % Done changed from 0 to 100
- Status changed from Ready For Testing to Closed
Applied in changeset 5bc5094baba5d18e8ee02b270f70cdea0ef59746.
#5
Updated by Walden Raines over 2 years ago
- Target version deleted (
219)
Fixes #23559 - fix breadcrumbs switcher in trends page