Refactor #23635
Optionally load facter
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assignee: |  Ewoud Kohl van Wijngaarden | ||
| Category: | - | ||
| Target version: | 1.19.0 | ||
| Difficulty: | Team Backlog: | ||
| Triaged: | Fixed in Releases: | ||
| Bugzilla link: | Found in Releases: | ||
| Pull request: | https://github.com/theforeman/foreman/pull/5589 | ||
Description
Facter is currently loaded in a few places. This is always to get the fqdn or domain which can be centralized to settings. It can then detect if those are already hardcoded. The benefit is that facter becomes optional.
Associated revisions
Refs #23635 - Stop relying on facter
The inclusion of facter is technically optional since it's a bundler
group. In practice there are direct calls to it.
This change relies on a change in Foreman core to ensure SETTINGS[:fqdn]
is set.
The benefit is that you can explicitly set the FQDN in your settings
file and avoid the use of the host FQDN altogether. This has the benefit
of decoupling from the actual host you run Foreman on.
Fixes #23635 - Centralize use of facter
We have a bundler group for facter. That implies it's optional but
before this change it wasn't With this change it's only required if no
domain and fqdn are set. This is still the default so in most cases it's
no difference, but at least we have centralized all use of facter to one
place.
History
#1
Updated by The Foreman Bot 2 months ago
- Assignee set to Ewoud Kohl van Wijngaarden
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/5589 added
#2
Updated by Michael Moll about 1 month ago
- Legacy Backlogs Release (now unused) set to 353
#3
Updated by Ewoud Kohl van Wijngaarden about 1 month ago
- % Done changed from 0 to 100
- Status changed from Ready For Testing to Closed
Applied in changeset a653e389fafbc6746500b378d76f86851cb9139d.