Project

General

Profile

Bug #23654

bridge interface facts don't imported in case of primary interface

Added by Maksim Malchuk almost 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Maksim Malchuk
Category:
Facts
Target version:
-
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5598, https://github.com/theforeman/foreman/pull/5597
Fixed in Releases:
1.24.0
Found in Releases:
1.17.0
Red Hat JIRA:

Description

Facts for primary interface not imported in case of virtual interfaces (bridge in this case):

2018-05-20T10:46:17 88de1713 [app] [D] We have following interfaces 'br-private, enp2s0f0, enp2s0f1, bond1.1005, br-ipo, br-ipo-nic, enp130s0f0, enp130s0f1, enp129s0f0, enp129s0f1, bond0, bond1' based on facts
2018-05-20T10:46:17 88de1713 [app] [D] Saving br_private NIC for host cloud-lab15.example.org
2018-05-20T10:46:18 88de1713 [app] [W] Saving br_private NIC for host cloud-lab15.example.org failed, skipping because:
2018-05-20T10:46:18 88de1713 [app] [W] Identifier has already been taken

This is because the information already in the database and should be updated instead of adding it again.

Related issues

Related to Ansible - Bug #23653: parsing facts break interfaces namesClosed
Related to Foreman - Bug #23655: vlan interface facts don't imported in case of ansible pluginReady For Testing
Related to Foreman - Bug #24073: Foreman fact parser unable to process NPAR NICs with underscoreNew2018-06-26

Associated revisions

Revision 5a76fcd4 (diff)
Added by Maksim Malchuk over 3 years ago

Fixes #23654 - update even virtual interface facts

When getting the scope we shouldn't rely on attributes and check all
the interfaces even virtual. This commit also add some debug logging.

Signed-off-by: Maksim Malchuk <>

History

#1 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5597 added

#2 Updated by Maksim Malchuk almost 5 years ago

  • Related to Bug #23653: parsing facts break interfaces names added

#3 Updated by Maksim Malchuk almost 5 years ago

  • Related to Bug #23655: vlan interface facts don't imported in case of ansible plugin added

#4 Updated by Maksim Malchuk almost 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5598 added

#5 Updated by Lukas Zapletal almost 5 years ago

  • Related to Bug #24073: Foreman fact parser unable to process NPAR NICs with underscore added

#6 Updated by Chris Roberts almost 5 years ago

  • Triaged set to Yes
  • Priority changed from High to Normal

#7 Updated by The Foreman Bot over 3 years ago

  • Fixed in Releases 1.24.0 added

#8 Updated by Maksim Malchuk over 3 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF