Bug #23673: restore on external database - Foreman Maintain - Foreman

Actions

Copy link

Bug #23673

closed

restore on external database

Added by Ales Dujicek almost 6 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Martin Bacovsky

Category:

Procedure

Target version:

Difficulty:

Triaged:

Bugzilla link:

1592387

Pull request:

https://github.com/theforeman/foreman_maintain/pull/200

Fixed in Releases:

Found in Releases:

Foreman - Nightly

Red Hat JIRA:

Description

in the lastest changes
https://github.com/theforeman/foreman_maintain/pull/169/commits/ba1c920e9019f3c712b6fea094927ad2759c4c72
in restore PR https://github.com/theforeman/foreman_maintain/pull/169

reappeared the problem with remote database

- Dropping databases
- Dropping databases                                                  [FAIL]
No services found matching your parameters
--------------------------------------------------------------------------------
Scenario [Restore backup] failed.
The following steps ended up in failing state:
  [restore-drop-databases]
Resolve the failed steps and rerun
the command. In case the failures are false positives,
use --whitelist="restore-drop-databases"

feature(:service).handle_services(spinner, 'start', :only => ['postgresql'])

fails because of empty service list - postgresql is not installed so it is removed from the list

we may consider removing the whole DropDatabases step
pg_restore is used with --clean flag anyway
https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/concerns/base_database.rb#L63
so I believe it is not necessary to clean database before restore

Actions

Copy link

Updated by Ales Dujicek almost 6 years ago

Bugzilla link set to 1592387

Actions

Copy link

Updated by Martin Bacovsky almost 6 years ago

Category set to Procedure
Status changed from New to Assigned
Assignee set to Martin Bacovsky
Triaged set to No
Team Backlog Ivan added

Actions

Copy link

Updated by Martin Bacovsky almost 6 years ago

Team Backlog Foreman Maintain added
Team Backlog deleted (~~Ivan~~)

All the services subcommands are affected when using remote DB's and the service is not present (though unused on the server). Will fix this at first.
We may revisit restore later with moving --reset feature to f-m.

Actions

Copy link