Refactor #23756

Improve wait_for_ajax

Added by Lukas Zapletal about 1 month ago. Updated 7 days ago.

Status:Closed
Priority:Normal
Assignee:Lukas Zapletal
Category:-
Target version:1.19.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/foreman/pull/5628

Description

We have two issues with wait_for_ajax.

1) Statement page.evaluate_script sometimes evaluates to nil leading to NoMethodError: undefined method `zero?' for nil:NilClass (e.g. in discovery integration tests)

2) Doing endless loop for nothing burns CPU time, adding a small delay will actually improve performance of JS tests because other processes can be served by the same CPU core while waiting.

Associated revisions

Revision c5c06be7
Added by Lukas Zapletal about 1 month ago

Fixes #23756 - improved wait_for_ajax

History

#1 Updated by The Foreman Bot about 1 month ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5628 added

#2 Updated by Tomer Brisker about 1 month ago

  • Legacy Backlogs Release (now unused) set to 353

#3 Updated by Lukas Zapletal about 1 month ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF