Refactor #23756
Improve wait_for_ajax
Description
We have two issues with wait_for_ajax.
1) Statement page.evaluate_script
sometimes evaluates to nil leading to NoMethodError: undefined method `zero?' for nil:NilClass (e.g. in discovery integration tests)
2) Doing endless loop for nothing burns CPU time, adding a small delay will actually improve performance of JS tests because other processes can be served by the same CPU core while waiting.
Associated revisions
History
#1
Updated by The Foreman Bot almost 5 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/5628 added
#2
Updated by Tomer Brisker almost 5 years ago
- Legacy Backlogs Release (now unused) set to 353
#3
Updated by Lukas Zapletal almost 5 years ago
- % Done changed from 0 to 100
- Status changed from Ready For Testing to Closed
Applied in changeset c5c06be7399a95e98e5ef67bc810803499b6dfa2.
#4
Updated by Tomer Brisker over 4 years ago
- Category set to Tests
Fixes #23756 - improved wait_for_ajax