Project

General

Profile

Refactor #23756

Improve wait_for_ajax

Added by Lukas Zapletal 4 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

We have two issues with wait_for_ajax.

1) Statement page.evaluate_script sometimes evaluates to nil leading to NoMethodError: undefined method `zero?' for nil:NilClass (e.g. in discovery integration tests)

2) Doing endless loop for nothing burns CPU time, adding a small delay will actually improve performance of JS tests because other processes can be served by the same CPU core while waiting.

Associated revisions

Revision c5c06be7 (diff)
Added by Lukas Zapletal 4 months ago

Fixes #23756 - improved wait_for_ajax

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5628 added

#2 Updated by Tomer Brisker 4 months ago

  • Legacy Backlogs Release (now unused) set to 353

#3 Updated by Lukas Zapletal 4 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker about 2 months ago

  • Category set to Tests

Also available in: Atom PDF