Feature #23768

Fact parser flag keep_subnet to prevent subnet override during fact upload

Added by Lukas Zapletal about 1 month ago. Updated 9 days ago.

Status:Closed
Priority:Normal
Assignee:Lukas Zapletal
Category:Importers
Target version:1.19.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/foreman/pull/5635

Description

Setting "Update subnets from facts" makes discovery impossible if taxonomy does not match the host leading to "Subnet is not defined for host's organization". Discovery uses standard core Puppet parser to recognize all interfaces, therefore discovery users must have all subnet taxonomy aligned with discovered host taxonomy, even if they don't plan to use all interfaces.

This patch adds flag keep_subnet which is added by discovery, when present subnet is never updated. This prevents the misbehavior when the flag is set.


Related issues

Related to Discovery - Bug #23224: Update subnets from facts breaks discovery Closed 04/11/2018

Associated revisions

Revision fcc2b55d
Added by Lukas Zapletal about 1 month ago

Fixes #23768 - keep_subnet flag to prevent subnet override (#5635)

History

#1 Updated by Lukas Zapletal about 1 month ago

  • Subject changed from Fact parser flag keep_subnet to prevend subnet override during fact upload to Fact parser flag keep_subnet to prevent subnet override during fact upload

#2 Updated by Lukas Zapletal about 1 month ago

  • Related to Bug #23224: Update subnets from facts breaks discovery added

#3 Updated by The Foreman Bot about 1 month ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5635 added

#4 Updated by Marek Hulán about 1 month ago

  • Legacy Backlogs Release (now unused) set to 353

#5 Updated by Lukas Zapletal about 1 month ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF