Plugins » Discovery

Hello Danny, this is a bug, yes.

Are you using quick provision, custom provision (Edit Host form) or auto-provisioning workflow? Every one of the three uses slightly different codepath. The check implemented in Foreman Core is probably hooked into New Host - Submit path while discovery uses slightly modified Edit Host form (or no form at all for the other two).

I suggest you to start with editing an existing host in Core - does not show any error? If not, that's a missing feature in Core and we need this to be implemented. If it does work correctly, then make sure that discovery triggers the check. I roughly looked in the codebase but could not find it where do we check the templates.

Hi Lukas, thanks for your reply.

I first noticed the issue with the 'custom provisioning' scenario, which uses the edit host form. I can't test auto-provision that easily at this point, but it seems that quick-provision has the same issue.

Some other findings that may be interesting:

1. I can edit an existing host and submit: it does not report the error in the provisioning templates.
2. I can edit an existing host, press the "Resolve" provisioning templates button: it also does not report the error.
3. I can preview the provisioning template using the edit template form: it does report the error in the template.
4. I can press the "Build" button for an existing host: it does report the error in the template.

I'm not sure if it is to be expected that the scenarios of bullet 1 and 2 are not showing the error. I can imagine that it is less relevant in those cases.

Without knowing the details, it seems to me that provisioning a discovered host exists of two steps (when comparing to the Foreman Core):

1. First edit the host (if applicable)
2. Immediately/automatically followed by the "Build" path of the host

Please correct me if I'm wrong, but this leads me to believe that the checks to triggers are probably part of the "Build" path instead of "Edit host" path in Foreman Core.

Does that make sense?

Thanks for your reply.

I noticed that the "Build" button for an existing host triggers a call to the URL path: "/hosts/<name>/review_before_build", which seems to be checking if the provisioning templates can be rendered (and probably triggers other checks as well). Shouldn't discovery also trigger the same check? As there could be more verification steps that are now skipped by discovery.

Again, feel free to correct me if I'm wrong, but this makes me believe that the 'reusable code' needed for this already exists in core. Wouldn't it be possible to include that check in discovery as well?

Because of this, I'm not really sure if it will be that useful to write an issue in core at this point.

Yes, discovery should reuse this for auto and quick provisioning.

For "Customize host" option Discovery actually renders Edit Host form from core. I know this is confusing.

Depending on which workflow you want the check to be present, that should go there. We can rule out auto provisioning because that's non interactive. So quick provision ("Provision" button) or "Customize host" button.