Project

General

Profile

Bug #239

Class import doesn't prune erased classes

Added by SyRenity Now about 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Importers
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

I imported some classes, which I later erased from disk.

Repeating import doesn't prune these classes.


Related issues

Related to Foreman - Bug #386: ImportClasses should be callable from a rake taskClosed2010-09-23

Associated revisions

Revision adcd0374 (diff)
Added by Paul Kelly almost 9 years ago

Fixes #239 - Erases environments and puppetclasses

The fix also includes a page in which the use selects the additions
and removals which they would wish to apply to their database.
Errors are reported and an opportunity is given to reapply the changes.

History

#1 Updated by Ohad Levy about 9 years ago

  • Target version set to 0.1-6

#2 Updated by Paul Kelly almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee changed from Ohad Levy to Paul Kelly
  • Branch set to bug/239-prune-erased-classes

The fix also includes a page in which the user selects the additions and removals which they would wish to apply to their database.
Errors are reported and an opportunity is given to reapply the changes.

#3 Updated by Ohad Levy almost 9 years ago

Paul Kelly wrote:

The fix also includes a page in which the user selects the additions and removals which they would wish to apply to their database.
Errors are reported and an opportunity is given to reapply the changes.

Would you mind adding tests?

#4 Updated by Paul Kelly almost 9 years ago

A few minor fixes
Tests added
NOTE that this branch consists of two commits, #239 and then #377, as the assert_select tests do not work without XHTML compliance

I would guess that git will find that the patch has already been applied if you were to apply this branch to develop after the separate #377 branch had been applied.

#5 Updated by Paul Kelly almost 9 years ago

  • % Done changed from 0 to 100

#6 Updated by Ohad Levy almost 9 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF