Project

General

Profile

Bug #23917

TLS disabled versions in smart proxy should be converted to string

Added by Stephen Benjamin about 1 month ago. Updated 8 days ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:

Description

If someone specifies settings in YAML like this:

```yaml
tls_disabled_versions:
- 1.1
```

Ruby will interpret it as a float. Currently, it must be quoted.
Ivan Necas [added a to_s to the dynflow smart proxy plugin](https://github.com/theforeman/smart_proxy_dynflow/pull/43#pullrequestreview-92019342) to fix this,
this commit makes smart proxy behavior the same.


Related issues

Related to Smart Proxy - Bug #21350: Allow restricting TLS versionClosed2017-10-17

Associated revisions

Revision dfc29877 (diff)
Added by Stephen Benjamin about 1 month ago

fixes #23917 - convert tls version to string

If someone specifies settings in YAML like this:

```yaml
tls_disabled_versions:
- 1.1
```

Ruby will interpret it as a float. Currently, it must be quoted.
Ivan Necas added a to_s to the dynflow smart proxy plugin to fix this,
this commit makes smart proxy behavior the same.

History

#1 Updated by The Foreman Bot about 1 month ago

  • Assignee set to Stephen Benjamin
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/587 added

#2 Updated by Stephen Benjamin about 1 month ago

  • Related to Bug #21350: Allow restricting TLS version added

#3 Updated by Timo Goebel about 1 month ago

  • Legacy Backlogs Release (now unused) set to 360

#4 Updated by The Foreman Bot about 1 month ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/589 added

#5 Updated by The Foreman Bot about 1 month ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/590 added

#6 Updated by Stephen Benjamin about 1 month ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF