Project

General

Profile

Actions

Bug #23917

closed

TLS disabled versions in smart proxy should be converted to string

Added by Stephen Benjamin over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:

Description

If someone specifies settings in YAML like this:

```yaml
tls_disabled_versions:
- 1.1
```

Ruby will interpret it as a float. Currently, it must be quoted.
@Ivan Necas [added a to_s to the dynflow smart proxy plugin](https://github.com/theforeman/smart_proxy_dynflow/pull/43#pullrequestreview-92019342) to fix this,
this commit makes smart proxy behavior the same.


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Feature #21350: Allow restricting TLS versionClosedStephen BenjaminActions
Actions #1

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Stephen Benjamin
  • Pull request https://github.com/theforeman/smart-proxy/pull/587 added
Actions #2

Updated by Stephen Benjamin over 6 years ago

Actions #3

Updated by Timo Goebel over 6 years ago

  • Translation missing: en.field_release set to 360
Actions #4

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/589 added
Actions #5

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/590 added
Actions #6

Updated by Stephen Benjamin over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by Tomer Brisker over 6 years ago

  • Triaged set to No
  • Fixed in Releases 1.18.0, 1.19.0 added
Actions

Also available in: Atom PDF