Project

General

Profile

Actions

Bug #2393

closed

Couple of models broken with audited 3.0.0

Added by Ivan Necas about 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
High
Assignee:
-
Category:
Audit Log
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

In audited 3.0.0, there is this change:

https://github.com/collectiveidea/audited/commit/ec4732fa214ad9e7c129c36acef1ca80779d079c

It adds audited column automatically as attr_protected, which means, that even with whitelist_attributes = false,
the models start being checked.

The solution: set whitelist_attirbutes to true and fix all the missing models with attr_accesible. I know at least
about Oranization, Location, Operatingsystem and ComputeResource that have this issue.

Note: right now, Gemfile locks the audited gem on rc1, which doesn't contain this change. Since the 3.0.0 is already
out, there should be no reason to keep that locked, and we should fix our code base instead.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #1743: Validation of name parameters always failsClosedOhad Levy07/10/2012Actions
Actions #1

Updated by Ivan Necas almost 11 years ago

  • Priority changed from Normal to High
Actions #2

Updated by Dominic Cleal almost 11 years ago

  • Category set to Audit Log
  • Target version set to 1.2.0
Actions #3

Updated by Ivan Necas almost 11 years ago

This btw. means, that foreman doesn't work properly on Fedora, since there already is audited-3.0.0:

http://koji.fedoraproject.org/koji/buildinfo?buildID=370392

Actions #4

Updated by Ohad Levy almost 11 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF