Project

General

Profile

Bug #2404

Updating environment name leads to 404

Added by Ivan Necas over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Joseph Magen
Category:
Web Interface
Target version:
1.2.0
Difficulty:
easy
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Steps to reproduce:

1. create environment "foo"
2. open of editing, change to "foo-bar", submit
3. you'll get invalid format message
4. change name to "foo_bar", submit
5. you get "Environment not found" error, nothing updated

Expected:

Environment updated successfully

Associated revisions

Revision 696420ff (diff)
Added by Joseph Magen over 6 years ago

fixes #2404 - prevents 404 when updating invalid name used as id

Revision ede82d1c (diff)
Added by Joseph Magen over 6 years ago

fixes #2404 - prevents 404 when updating invalid name used as id
(cherry picked from commit 696420ff788834dad99352d326fa74fd764572cd)

History

#1 Updated by Sam Kottler over 6 years ago

  • Category set to Web Interface
  • Status changed from New to Assigned
  • Assignee set to Sam Kottler
  • Target version set to 1.2.0
  • Difficulty set to easy

#2 Updated by Sam Kottler over 6 years ago

Thanks for the report!

Do you get a message when trying to submit that it contains invalid characters? I do, which prevents me from submitted with the new name.

#3 Updated by Ivan Necas over 6 years ago

I get the message, but it's part of the edit form, so that I can change the name a resubmit again.

#4 Updated by Sam Kottler over 6 years ago

I see what you mean now that I've hit submit twice - working on a patch now.

#5 Updated by Greg Sutcliffe over 6 years ago

  • Priority changed from Normal to Low

#6 Updated by Ohad Levy over 6 years ago

  • Assignee deleted (Sam Kottler)

#7 Updated by Joseph Magen over 6 years ago

  • Assignee set to Joseph Magen

#8 Updated by Joseph Magen over 6 years ago

  • Status changed from Assigned to Ready For Testing

#9 Updated by Joseph Magen over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF