Bug #24139
closed
foreman_salt does not recognize vlan interfaces (and bonds/bridges) as virtual interfaces
Description
The foreman_salt FactParser doesn’t recognize VLAN interfaces (and bond/bridges) as virtual interfaces. The first cause is that VLAN interfaces are often defined is <iface>.<vlan>. That syntax wasn't recognized by foreman core until: https://github.com/theforeman/foreman/pull/5597
That change makes foreman core recognize the syntax, however it still doesn't work with the salt plugin. The cause is that the foreman_salt FactParser doesn’t add additional attributes based on VIRTUAL, BRIDGES, BONDS regex of foreman core.
It seems that adding a call to ‘set_additional_attributes’ in the FactParser can fix that. I will add a PR for that.
This came up as part of this discussion: https://community.theforeman.org/t/detection-of-changes-in-host-network-configuration-by-foreman/10039
Updated by Danny S over 6 years ago
Note that a result of this behavior is that a physical NIC can disappear in the administration of foreman, in case a vlan interface matches with its new mac address and IP address with the information of the physical interface in an earlier stage.
Updated by The Foreman Bot over 6 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman_salt/pull/80 added
Updated by Anonymous over 6 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman_salt|377b3cae84f5b6308cc53a67597ea67547485f86.