Feature #2414
closed
Remove Puppet from Foreman core
Added by Dominic Cleal over 11 years ago.
Updated about 11 years ago.
Category:
Puppet integration
|
|
Description
We need to complete removing the Puppet dependency from Foreman core, so all Puppet usage is in the smart proxy only. This will make it optional for people who don't use Puppet, plus avoid conflicts we've seen when loading Puppet as a library into the full Rails application (monkey patching).
Some tasks:
1. Reports need to be parsed in the report handler, then uploaded as JSON etc. (app/models/report.rb)
2. Fact uploads need to be hashes only, no Puppet::Node::Facts (app/models/host/managed.rb)
3. PuppetSetting checks the PUPPETVERSION constant (lib/puppet_setting.rb)
- Assignee deleted (
Ohad Levy)
Related is that we use Facter too in lib/foreman/default_settings/loader.rb and lib/tasks/reset_permissions.rake to get the current domain and Puppet version again, plus in DB migrations.
I can take it out of the settings in my plugin-settings PR if needed - it's only used to get the domain, I can add a fallback to shell out to `dnsdomainname` if Facter can't be loaded. Same can probably be done in the permissions.
Greg Sutcliffe wrote:
I can take it out of the settings in my plugin-settings PR if needed - it's only used to get the domain, I can add a fallback to shell out to `dnsdomainname` if Facter can't be loaded. Same can probably be done in the permissions.
I wouldn't worry for now, since we have the same use case in the settings loader. When we solve it there we can update both. Facter's less of a problem anyway, maybe it's even a reasonable dependency.
Puppet #20136 was another issue introduced by monkey patches distributed by Puppet.
(I'm linking other issues introduced by Puppet's patches to this issue as a tracker.)
- Target version set to 1.3.0
- Description updated (diff)
- Status changed from New to Ready For Testing
- Assignee set to Greg Sutcliffe
- % Done changed from 0 to 50
- Status changed from Ready For Testing to Closed
- % Done changed from 50 to 100
- Related to Bug #3030: Facter isn't loaded, but is referenced in DB migrations etc. added
- Related to Bug #3236: prod2dev assumes all production tables exist in development added
Also available in: Atom
PDF
Updated by 
Updated by