Project

General

Profile

Actions

Bug #24150

closed

Icon broken for Operating Systems based on XenServer

Added by David Coppit over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

In operatingsystems_helper.rb, the code has a case statement based on record.name, defaulting to record.family if there is no match.

For operating systems based on XenServer, this defaults to the value of "Xenserver" (lower case "s"). However, the image is named "XenServer.png" (upper case "s").

One workaround is this patch:

--- operatingsystems_helper.rb.orig 2018-07-03 16:33:15.763945937 0000
++ operatingsystems_helper.rb 2018-07-03 16:49:26.710467826 +0000
@ -43,6 +43,10 @
record.family
end

+ if family == "Xenserver"
+ family = "XenServer"
+ end

image_tag(family
".png", opts) + " "
end

However, a better fix might be to rename the family to "XenServer".

I also wonder if the case statement should be based on record.family...

Actions #1

Updated by boaz shust over 5 years ago

  • Assignee set to boaz shust
Actions #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6328 added
Actions #3

Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Tomer Brisker about 5 years ago

  • Fixed in Releases 1.21.0 added
Actions #5

Updated by Tomer Brisker about 5 years ago

  • Category set to Web Interface
Actions

Also available in: Atom PDF