Bug #24150
closedIcon broken for Operating Systems based on XenServer
Description
In operatingsystems_helper.rb, the code has a case statement based on record.name, defaulting to record.family if there is no match.
For operating systems based on XenServer, this defaults to the value of "Xenserver" (lower case "s"). However, the image is named "XenServer.png" (upper case "s").
One workaround is this patch:
--- operatingsystems_helper.rb.orig 2018-07-03 16:33:15.763945937 0000
++ operatingsystems_helper.rb 2018-07-03 16:49:26.710467826 +0000@ -43,6 +43,10
@
record.family
end
+ if family == "Xenserver"
+ family = "XenServer"
+ end
image_tag(family".png", opts) + " "
end
However, a better fix might be to rename the family to "XenServer".
I also wonder if the case statement should be based on record.family...
Updated by The Foreman Bot about 6 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/6328 added
Updated by Anonymous about 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset d4aa8d22c520fc7a31c0e62508267ea4230239c5.