Project

General

Profile

Bug #24150

Icon broken for Operating Systems based on XenServer

Added by David Coppit almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

In operatingsystems_helper.rb, the code has a case statement based on record.name, defaulting to record.family if there is no match.

For operating systems based on XenServer, this defaults to the value of "Xenserver" (lower case "s"). However, the image is named "XenServer.png" (upper case "s").

One workaround is this patch:

--- operatingsystems_helper.rb.orig 2018-07-03 16:33:15.763945937 0000
+
+ operatingsystems_helper.rb 2018-07-03 16:49:26.710467826 +0000
@ -43,6 +43,10 @
record.family
end

+ if family == "Xenserver"
+ family = "XenServer"
+ end

image_tag(family
".png", opts) + " "
end

However, a better fix might be to rename the family to "XenServer".

I also wonder if the case statement should be based on record.family...

Associated revisions

Revision d4aa8d22 (diff)
Added by Boaz Shuster over 1 year ago

Fixes #24150 - Icon broken for Operating Systems

Signed-off-by: Boaz Shuster <>

History

#1 Updated by boaz shust over 1 year ago

  • Assignee set to boaz shust

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6328 added

#3 Updated by Anonymous over 1 year ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker over 1 year ago

  • Fixed in Releases 1.21.0 added

#5 Updated by Tomer Brisker over 1 year ago

  • Category set to Web Interface

Also available in: Atom PDF