Project

General

Profile

Actions
Copy link

Bug #24186

closed

vSphere error handling can break

Added by Timo Goebel about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Timo Goebel
Category:
Compute resources - VMware
Target version:
1.19.0
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5782
Fixed in Releases:
1.19.0
Found in Releases:
1.15.0
Red Hat JIRA:

Description

When rescue vsphere exceptions in vm_create, the code assumes vm is set. This can lead to the following exception:

NameError: undefined local variable or method `vm' for #<Foreman::Model::Vmware:0x007f27f4791c38>

Actions
Copy link
 #1

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5782 added
Actions
Copy link
 #2

Updated by Timo Goebel about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Greg Sutcliffe almost 7 years ago

  • Fixed in Releases 1.15.0 added
Actions
Copy link
 #4

Updated by Greg Sutcliffe almost 7 years ago

  • Fixed in Releases deleted (1.15.0)
Actions
Copy link
 #5

Updated by Marek Hulán almost 7 years ago

  • Translation missing: en.field_release set to 353
Actions
Copy link

Also available in: Atom PDF