Project

General

Profile

Bug #24186

vSphere error handling can break

Added by Timo Goebel about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Timo Goebel
Category:
Compute resources - VMware
Target version:
1.19.0
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5782
Fixed in Releases:
1.19.0
Found in Releases:
1.15.0

Description

When rescue vsphere exceptions in vm_create, the code assumes vm is set. This can lead to the following exception:

NameError: undefined local variable or method `vm' for #<Foreman::Model::Vmware:0x007f27f4791c38>

Associated revisions

Revision 3baac1fa (diff)
Added by Timo Goebel about 2 years ago

fixes #24186 - improve vsphere error handling

History

#1 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5782 added

#2 Updated by Timo Goebel about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#3 Updated by Greg Sutcliffe about 2 years ago

  • Fixed in Releases 1.15.0 added

#4 Updated by Greg Sutcliffe about 2 years ago

  • Fixed in Releases deleted (1.15.0)

#5 Updated by Marek Hulán about 2 years ago

  • Legacy Backlogs Release (now unused) set to 353

Also available in: Atom PDF