Refactor #24281: Settings model have duplicate code on both create and create! class methods - Foreman

Refactor #24281

Settings model have duplicate code on both create and create! class methods

Added by Ido Kanner over 4 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Low

Assignee:

Category:

Settings

Target version:

Difficulty:

Triaged:

No

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5847

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The settings model has two class methods of create and create!.
They both have duplicate code.

Associated revisions

Revision 9c853eec (diff)
Added by Ido Kanner over 4 years ago

Refs #24281 - Refactor class methods of create and create!

History

#1 Updated by The Foreman Bot over 4 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/5847 added

#2 Updated by Marek Hulán over 4 years ago

Target version set to 1.20.0
Status changed from Ready For Testing to Closed
Fixed in Releases 1.20.0 added

#3 Updated by Tomer Brisker over 4 years ago

Category set to Settings

Also available in: Atom PDF