Refactor #24281: Settings model have duplicate code on both create and create! class methods - Foreman

Actions

Refactor #24281

closed

Settings model have duplicate code on both create and create! class methods

Added by Ido Kanner over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Low

Assignee:

Category:

Settings

Target version:

Difficulty:

Triaged:

No

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5847

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The settings model has two class methods of create and create!.
They both have duplicate code.

Actions

#1

Updated by The Foreman Bot over 6 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/5847 added

Actions

#2

Updated by Marek Hulán over 6 years ago

Status changed from Ready For Testing to Closed
Target version set to 1.20.0
Fixed in Releases 1.20.0 added

Actions

#3

Updated by Tomer Brisker about 6 years ago

Category set to Settings

Actions

Also available in: Atom PDF