Project

General

Profile

Bug #24298

Some audits show 'missing' instead of name

Added by Daniel Lobato Garcia 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Audit Log
Target version:

Description

To reproduce:

1. Go to a product.
2. In tab "Details", change "Sync plan" to a plan called 'test sync plan'.
3. Go to Audits.

Results: The latest audit says something like "Sync plan changed from N/A to Missing(ID: 1)". If you click on the details, it shows the correct text.
Expected result: "Sync plan changed from N/A to test sync plan"


Related issues

Related to Foreman - Bug #24844: Audits display missing id for non-main objects changesClosed

Associated revisions

Revision f501c49e (diff)
Added by Daniel Lobato Garcia about 2 months ago

Fixes #24298 - Some audits show 'Missing ID' instead of name

This happens when you're visiting the index page. The helper relies on
'@audit' to generate some of the audits. This does not work, since
@audit is only set when you view the details page of an audit.

For this reason, as an example changing fields of a host with
associations, like the puppet proxy, does not show the proper value in
the index, but it does show the proper value on the details page.

See the issue in Redmine for a reproduced with Katello sync plans.

History

#1 Updated by Daniel Lobato Garcia 2 months ago

  • Category changed from Sync Plans to Audit Log
  • Project changed from Katello to Foreman

Moving to Foreman as I found the issue and it's in Foreman actually.

#2 Updated by Daniel Lobato Garcia 2 months ago

  • Subject changed from Sync plan audit is shows 'missing' instead of name to Some audits show 'missing' instead of name

#3 Updated by The Foreman Bot 2 months ago

  • Assignee set to Daniel Lobato Garcia
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5857 added

#4 Updated by Daniel Lobato Garcia 2 months ago

  • Target version set to 1.19.0

Ideally this should go in the next 1.18 too

#5 Updated by Daniel Lobato Garcia 2 months ago

  • Bugzilla link set to 1607820

#6 Updated by Tomer Brisker about 2 months ago

  • Target version changed from 1.19.0 to 1.18.1

#7 Updated by Daniel Lobato Garcia about 2 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by The Foreman Bot about 2 months ago

  • Pull request https://github.com/theforeman/foreman/pull/5914 added

#9 Updated by The Foreman Bot about 2 months ago

  • Pull request https://github.com/theforeman/foreman/pull/5915 added

#10 Updated by The Foreman Bot about 2 months ago

  • Pull request https://github.com/theforeman/foreman/pull/5916 added

#11 Updated by Tomer Brisker about 2 months ago

  • Fixed in Releases 1.18.1, 1.19.0, 1.20.0 added

#12 Updated by Marek Hulán 15 days ago

  • Related to Bug #24844: Audits display missing id for non-main objects changes added

Also available in: Atom PDF