Project

General

Profile

Bug #24345

Breadcrumbs isn't refreshed properly after visiting host edit form

Added by Marek Hulán over 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

reproducing steps:
go to hosts > click edit > click submit > click the breadcrumb sibling selector and pick another host.
its lands in another_host/edit because it uses the breadcrumb-bar from the previews mounting.

another instance:
go to hosts > click edit > open a resource switcher, close it > click submit > click the breadcrumb sibling selector and pick another host, you end up in host instead of show.

This was partially workarounded by #23290 but then reverted because it caused a regression with vmware provisioning. As stated in the reverting PR, the real cause is probably not turbolinks+react, adding the comment here too

The real cause of wrong links in bredcrumb switcher is that we don't detect when switcherItemUrl changes and cached items should be reloaded. This condition should be updated to check it:
https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/BreadcrumbBar/BreadcrumbBar.js#L17-L19

Related issues

Related to Foreman - Bug #24320: Unable to provision on Vmware, no storage data submittedClosed
Copied from Foreman - Bug #23290: React + Turbolinks integration break when submitting formsClosed

Associated revisions

Revision c79888ab (diff)
Added by Maria Agaphontzev 7 months ago

Fixes #24345 - fix breadcrumbs item url

History

#1 Updated by Marek Hulán over 1 year ago

  • Copied from Bug #23290: React + Turbolinks integration break when submitting forms added

#2 Updated by Marek Hulán over 1 year ago

  • Related to Bug #24320: Unable to provision on Vmware, no storage data submitted added

#3 Updated by Tomer Brisker about 1 year ago

  • Assignee set to Avi Sharvit

#4 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/6382 added

#5 Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing

#6 Updated by Walden Raines 10 months ago

  • Assignee changed from Avi Sharvit to Maria Agaphontzev

#7 Updated by Tomer Brisker 7 months ago

  • Fixed in Releases 1.22.0 added

#8 Updated by Anonymous 7 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF