Project

General

Profile

Actions

Bug #24345

closed

Breadcrumbs isn't refreshed properly after visiting host edit form

Added by Marek Hulán almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

reproducing steps:
go to hosts > click edit > click submit > click the breadcrumb sibling selector and pick another host.
its lands in another_host/edit because it uses the breadcrumb-bar from the previews mounting.

another instance:
go to hosts > click edit > open a resource switcher, close it > click submit > click the breadcrumb sibling selector and pick another host, you end up in host instead of show.

This was partially workarounded by #23290 but then reverted because it caused a regression with vmware provisioning. As stated in the reverting PR, the real cause is probably not turbolinks+react, adding the comment here too

The real cause of wrong links in bredcrumb switcher is that we don't detect when switcherItemUrl changes and cached items should be reloaded. This condition should be updated to check it:
https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/BreadcrumbBar/BreadcrumbBar.js#L17-L19

Related issues 2 (0 open2 closed)

Related to Foreman - Bug #24320: Unable to provision on Vmware, no storage data submittedClosedMarek HulánActions
Copied from Foreman - Bug #23290: React + Turbolinks integration break when submitting formsClosedAvi SharvitActions
Actions #1

Updated by Marek Hulán almost 6 years ago

  • Copied from Bug #23290: React + Turbolinks integration break when submitting forms added
Actions #2

Updated by Marek Hulán almost 6 years ago

  • Related to Bug #24320: Unable to provision on Vmware, no storage data submitted added
Actions #3

Updated by Tomer Brisker almost 6 years ago

  • Assignee set to Avi Sharvit
Actions #4

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6382 added
Actions #5

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
Actions #6

Updated by Walden Raines over 5 years ago

  • Assignee changed from Avi Sharvit to Maria Agaphontzev
Actions #7

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.22.0 added
Actions #8

Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF