Project

General

Profile

Bug #24370

PUT requests content is logged in info level

Added by Hart Mel almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:

Description

In default log level (info), the PUT requests are logged with their content. When use hammer cli to upload big files, it will cause production.log to grow to be as big as upload contents.


2018-07-24T12:58:12 [I|kat|db881] PUT: https://myforeman.company.com/pulp/api/v2/content/uploads/415e1ac9-4050-47a2-86b5-bd916c20b85f/0/: <ED><AB><EE><DB>^C^@^@^@^@^Ajre-10.0.2-10.0.2-ga^@^@^@^@^@^@^@
^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^A^@^E^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@<8E><AD><E8>^A^@^@^@^@^@^@^@^E^@^@^@T^@^@^@>^@^@^@^G^@^@^@D^@^@^@^P^@^@^A^M^@^@^@^F^@
^@^@^@^@^@^@^A^@^@^C<E8>^@^@^@^D^@^@^@,^@^@^@^A^@^@^C<EC>^@^@^@^G^@^@^@0^@^@^@^P^@^@^C<EF>^@^@^@^D^@^@^@@^@^@^@^Aac83d27ef2e19aad35bb9648826ba3bc64d9e6e0^@^@^@^@^CŹ<CC><CE>xX<FD><8E>^?ˁ`n<84>^Co;<CD>k^N
<E9><BC>T^@^@^@>^@^@^@^G<FF><FF><FF><B0>^@^@^@^P^@^@^@^@<8E><AD><E8>^A^@^@^@^@^@^@^@7^@^B<E4><DC>^@^@^@?^@^@^@^G^@^B<E4><CC>^@^@^@^P^@^@^@d^@^@^@^H^@^@^@^@^@^@^@^A^@^@^C<E8>^@^@^@^F^@^@^@^B^@^@^@^A^@^@^C
<E9>^@^@^@^F^@^@^@^M^@^@^@^A^@^@^C<EA>^@^@^@^F^@^@^@^T^@^@^@^A^@^@^C<EC>^@^@^@      ^@^@^@^W^@^@^@^A^@^@^C<ED>^@^@^@        ^@^@^@J^@^@^@^A^@^@^C<EE>^@^@^@^D^@^@^A8^@^@^@^A^@^@^C<EF>^@^@^@^F^@^@^A<^@^@^@
^A^@^@^C<F1>^@^@^@^D^@^@^AT^@^@^@^A^@^@^C<F3>^@^@^@^F^@^@^AX^@^@^@^A^@^@^C<F6>^@^@^@^F^@^@^Ag^@^@^@^A^@^@^C<F8>^@^@^@    ^@^@^A^?^@^@^@^A^@^@^C<FC>^@^@^@^F^@^@^A<91>^@^@^@^A^@^@^C<FD>^@^@^@^F^@^@^A<99>^@
^@^@^A^@^@^C<FE>^@^@^@^F^@^@^A<9F>^@^@^@^A^@^@^D^@^@^@^@^F^@^@^A<A6>^@^@^@^A^@^@^D^A^@^@^@^F^@^@<9F><B8>^@^@^@^A^@^@^D^B^@^@^@^F^@^@<E9><FA>^@^@^@^A^@^@^D^D^@^@^@^D^@^A|$^@^@^B@^@^@^D^F^@^@^@^C^@^A<85>$^@
^@^B@^@^@^D       ^@^@^@^C^@^A<89><A4>^@^@^B@^@^@^D


Related issues

Related to Katello - Bug #23785: Do not log large response bodiesDuplicate

Associated revisions

Revision b20500a9 (diff)
Added by Thomas McKay almost 2 years ago

fixes #24370 - don't log binary upload contents

Revision 4401b025 (diff)
Added by Thomas McKay almost 2 years ago

refs #24370 - correct crane config

Revision c4ec6738
Added by Chris Duryee almost 2 years ago

Merge pull request #206 from thomasmckay/24370-no-log-binary

fixes #24370 - don't log binary upload contents

History

#1 Updated by Hart Mel almost 2 years ago

  • Related to Bug #23785: Do not log large response bodies added

#2 Updated by Hart Mel almost 2 years ago

Probably already fixed in #23785 ?

#3 Updated by Andrew Kofink almost 2 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.9.0
  • Assignee set to Thomas McKay

#4 Updated by Stephen Benjamin almost 2 years ago

Doesn't look like it, uploading repository content still gets logged.

#5 Updated by Thomas McKay almost 2 years ago

  • Status changed from New to Assigned
  • Team Backlog Tom added

#6 Updated by Thomas McKay almost 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/runcible/pull/206 added

#7 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/puppet-katello_devel/pull/170 added

#8 Updated by Zach Huntington-Meath over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF