Project

General

Profile

Refactor #24380

only load bookmarks when the dropdown is clicked

Added by Ohad Levy 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Foreman keeps loading the bookmarks, even if the dropdown has not opened, in recent version (since #20839) the bookmarks are loaded via API.
I would like to fetch the data only when the dropdown is actually clicked instead of always.


Related issues

Related to Foreman - Feature #24544: Add tests to 'load bookmarks on demand'Closed

Associated revisions

Revision 825acd63 (diff)
Added by Ohad Levy 5 months ago

fixes #24380 - load bookmarks on demand

This commits change that bookmarks are fetched (on every index action)
only once the bookmarks dropdown is opneded, this avoids extra API
call on most index pages when users don't use bookmarks.

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5872 added

#2 Updated by Ohad Levy 5 months ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Marek Hulán 5 months ago

  • Target version set to 1.20.0
  • Fixed in Releases 1.20.0 added

#4 Updated by Ohad Levy 4 months ago

  • Related to Feature #24544: Add tests to 'load bookmarks on demand' added

Also available in: Atom PDF