Project

General

Profile

Bug #24387

Telemetry buckets need to be set in seconds, not miliseconds

Added by Ivan Necas 9 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ivan Necas
Category:
Logging
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5874
Team Backlog:
Fixed in Releases:
1.20.0
Found in Releases:
1.18.0

Description

I was hitting an issue with the statsd buckets. All the requests were falling into all buckets we had, which was strange. It turns out the buckets need to be defined in seconds, not miliseconds.

Associated revisions

Revision 69edab72 (diff)
Added by Ivan Necas 9 months ago

Fixes #24387 - defined telemetry buckets in seconds

Also, add more granular buckets, the scale inspired by
https://github.com/prometheus/client_golang\
/blob/1ba60c7d585/prometheus/histogram.go#L59

History

#1 Updated by The Foreman Bot 9 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5874 added

#2 Updated by Lukas Zapletal 9 months ago

  • Found in Releases 1.18.0 added
  • Fixed in Releases 1.20.0 added

#3 Updated by Ivan Necas 9 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker 6 months ago

  • Category set to Logging

Also available in: Atom PDF