Project

General

Profile

Actions
Copy link

Bug #24503

closed

snippets macro does not render a snippet partial from filesystem

Added by Timo Goebel over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Timo Goebel
Category:
Templates
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5901
Fixed in Releases:
1.20.0
Found in Releases:
Red Hat JIRA:

Description

The snippets macro does not work anymore. It errors with "undefined method: render".

I believe it hasn't worked before as it tried to render a snippet from `app/views/unattended/snippets`, but the folder does not exist.

If I revert the template scope refactoring and create the folder, it errors with "AbstractController::DoubleRenderError in ProvisioningTemplatesController#preview"

In addition, the method is potentially dangerous as it allows a user to use ../

<%= snippets('../provisioning_templates/snippet/puppet.conf') %>

I was not able to break out of app/views but I guess we should not rely on that.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Refactor #22529: Refactor Template rendering to use a proper rendering serviceClosedTimo GoebelActions
Actions
Copy link
 #1

Updated by Timo Goebel over 6 years ago

  • Related to Refactor #22529: Refactor Template rendering to use a proper rendering service added
Actions
Copy link
 #2

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Timo Goebel
  • Pull request https://github.com/theforeman/foreman/pull/5901 added
Actions
Copy link
 #3

Updated by Tomer Brisker about 6 years ago

  • Fixed in Releases 1.20.0 added
Actions
Copy link
 #4

Updated by Timo Goebel about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF