Actions
Bug #24503
closedsnippets macro does not render a snippet partial from filesystem
Description
The snippets macro does not work anymore. It errors with "undefined method: render".
I believe it hasn't worked before as it tried to render a snippet from `app/views/unattended/snippets`, but the folder does not exist.
If I revert the template scope refactoring and create the folder, it errors with "AbstractController::DoubleRenderError in ProvisioningTemplatesController#preview"
In addition, the method is potentially dangerous as it allows a user to use ../
<%= snippets('../provisioning_templates/snippet/puppet.conf') %>
I was not able to break out of app/views but I guess we should not rely on that.
Updated by Timo Goebel over 6 years ago
- Related to Refactor #22529: Refactor Template rendering to use a proper rendering service added
Updated by The Foreman Bot over 6 years ago
- Status changed from New to Ready For Testing
- Assignee set to Timo Goebel
- Pull request https://github.com/theforeman/foreman/pull/5901 added
Updated by Timo Goebel over 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset dca37b20738803df5169ed9a6fbdb5d79511940e.
Actions