Project

General

Profile

Bug #24551

Puppet class fails loading in UI when the attribute order is created with upper case characters

Added by Ori Rabin 8 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Smart Variables
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1596853

Description of problem:
Puppet class fails loading in UI when the attribute order is created with upper case characters

Version-Release number of selected component (if applicable):
satellite-6.3.1-3.el7sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Navigate to the Satellite UI -> Configure -> Classes
2. Select a puppet class -> Smart Class Parameter. Add a new added a new `Prioritize attribute order` with some upper case letters on it. eg., `test_version,UPPER_TEST`. Add a matcher at the same time with some values. eg., `test_version=4.1.0,UPPER_TEST=true` in the same UI transaction.
3. Click Submit.

Actual results:
The order and matcher would be created, but the puppet class cannot be loaded in Satellite UI anymore. Reason: The lookup_keys table changed the order to all lowercase and stored it. The lookup_values table saved the original upper case letters. This caused inconsistency between the tables and broke the UI.

Expected results:
Either do not allow upper case letters in `Prioritize attribute order` field or save all lower case in lookup_values table too - to keep the data consistent.

Additional info:

Associated revisions

Revision 892fc075 (diff)
Added by Ori Rabin 3 months ago

Fixes #24551 - Change all matcher attributes to lowercase

History

#1 Updated by Ori Rabin 8 months ago

  • Priority changed from High to Normal
  • Assignee set to Ori Rabin
  • Status changed from New to Assigned
  • Category changed from PuppetCA to Smart Variables
  • Subject changed from Puppet class fails loading in UI when the attribute order is created with upper case characters to Puppet class fails loading in UI when the attribute order is created with upper case characters

#2 Updated by The Foreman Bot 7 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5951 added

#3 Updated by Tomer Brisker 3 months ago

  • Fixed in Releases 1.21.0 added

#4 Updated by Ori Rabin 3 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF