Project

General

Profile

Refactor #24590

reduce js library duplication by plugins

Added by Ohad Levy 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

it seems that a few npm packages were not included in the webpack vendor bundle.


Related issues

Related to Foreman - Bug #22114: foreman webpack vendor asset file can change if plugins are installedClosed2018-01-02

Associated revisions

Revision 9b946ada (diff)
Added by Ohad Levy 4 months ago

fixes #24590 - adds missing packages to the vendor bundle

This reduces plugin bundles, for example:

Before
foreman_ansible-5d349cbac84354973187.js 191 kB
foreman_remote_execution-f5d74437300f4b3c5b05.js 151 kB
vendor-006110822861b6733af8.js 3.87 MB
bundle-f60c9313893e777715a8.js 183 kB

After
foreman_ansible-195d8978baa8035f4120.js 168 kB
foreman_remote_execution-b9b0d6b91ed13025743c.js 128 kB
vendor-b6241de5b97d3aac0bf8.js 3.89 MB
bundle-a70a5008863bfd5b2929.js 161 kB

The large percentage remaining is the component registry it self, which
should be shared, but probably in another PR.

History

#1 Updated by Ohad Levy 4 months ago

  • Related to Bug #22114: foreman webpack vendor asset file can change if plugins are installed added

#2 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ohad Levy
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5939 added

#3 Updated by Tomer Brisker 4 months ago

  • Fixed in Releases 1.20.0 added

#4 Updated by Ohad Levy 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF