Project

General

Profile

Actions
Copy link

Bug #24591

closed

Incorrect error reporting for MS DHCP

Added by Lukas Zapletal about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
DHCP
Target version:
Foreman - 1.20.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/603
Fixed in Releases:
Foreman - 1.20.0
Found in Releases:
1.15.0, 1.15.1, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.17.0, 1.17.2, Foreman - 1.18.0, Foreman - 1.18.1
Red Hat JIRA:

Description

When request fail, error is not reported correctly and this is thrown instead:

E, [2018-08-10T19:55:09.502316 42606010] ERROR -- : undefined local variable or method `opts' for ms dhcp server:Proxy::DHCP::NativeMS::Provider
D, [2018-08-10T19:55:09.502316 42606010] DEBUG -- : undefined local variable or method `opts' for ms dhcp server:Proxy::DHCP::NativeMS::Provider (NameError)
C:/smart-proxy-1.18.0/modules/dhcp_native_ms/dhcp_native_ms_main.rb:224:in `rescue in build_lease'
C:/smart-proxy-1.18.0/modules/dhcp_native_ms/dhcp_native_ms_main.rb:212:in `build_lease'
C:/smart-proxy-1.18.0/modules/dhcp_native_ms/dhcp_native_ms_main.rb:209:in `block in all_leases'
C:/smart-proxy-1.18.0/modules/dhcp_native_ms/dhcp_native_ms_main.rb:209:in `map'
C:/smart-proxy-1.18.0/modules/dhcp_native_ms/dhcp_native_ms_main.rb:209:in `all_leases'
C:/smart-proxy-1.18.0/modules/dhcp_native_ms/dhcp_native_ms_main.rb:109:in `unused_ip'
C:/smart-proxy-1.18.0/modules/dhcp/dhcp_api.rb:34:in `block in <class:DhcpApi>'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/sinatra-2.0.3/lib/sinatra/base.rb:1635:in `call'
C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/sinatra-2.0.3/lib/sinatra/base.rb:1635:in `block in compile!'

Related issues 2 (0 open — 2 closed)

Related to Smart Proxy - Bug #18070: When adding a new dhcp reservation, ip and mac addresses should be checked not only against existing reservations but leases as wellClosed01/13/2017Actions
Related to Foreman - Bug #25024: Failed to fetch a free IP from proxy - undefined local variable or method `opts' for ms dhcp server:Proxy::DHCP::NativeMS::ProviderDuplicateActions
Actions
Copy link
 #1

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/603 added
Actions
Copy link
 #2

Updated by Tomer Brisker about 6 years ago

  • Related to Bug #18070: When adding a new dhcp reservation, ip and mac addresses should be checked not only against existing reservations but leases as well added
Actions
Copy link
 #3

Updated by Tomer Brisker about 6 years ago

  • Fixed in Releases added
  • Found in Releases 1.15.0, 1.15.1, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.17.0, 1.17.2 added
Actions
Copy link
 #4

Updated by Anonymous about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by Ewoud Kohl van Wijngaarden almost 6 years ago

  • Fixed in Releases 1.20.0 added
  • Fixed in Releases deleted ()
  • Found in Releases 1.18.1 added
  • Found in Releases deleted ()
Actions
Copy link
 #6

Updated by Ewoud Kohl van Wijngaarden almost 6 years ago

  • Target version set to 1.20.0
Actions
Copy link
 #7

Updated by Ewoud Kohl van Wijngaarden almost 6 years ago

  • Found in Releases 1.18.0 added
  • Found in Releases deleted ()
Actions
Copy link
 #8

Updated by Lukas Zapletal almost 6 years ago

  • Related to Bug #25024: Failed to fetch a free IP from proxy - undefined local variable or method `opts' for ms dhcp server:Proxy::DHCP::NativeMS::Provider added
Actions
Copy link

Also available in: Atom PDF